feat: Add export_id field on Taxonomy#145
Conversation
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
|
||
| return True, task, tag_import_plan | ||
| except Exception as exception: # pylint: disable=broad-exception-caught | ||
| except Exception as exception: |
There was a problem hiding this comment.
This generated a warning on the lint
openedx_tagging/core/tagging/migrations/0015_taxonomy_export_id.py
Outdated
Show resolved
Hide resolved
pomegranited
left a comment
There was a problem hiding this comment.
Couple of nits/questions, but everything else looks perfect. 👍
@ChrisChV Let me know if you need me to do a second review?
- I tested this in my devstack using the PR test instructions
- I read through the code
-
I checked for accessibility issuesN/A here - Includes documentation -- adds help_text for new field, docstrings where needed
- User-facing strings are extracted for translation
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Description
This PR adds a new
export_idfield onTaxonomymodel.Support information
Testing instruction
Before run migration
python manage.py runsever.python manage.py createsuperuser.python manage.py migrate.export_idexport_idon Django admin.export_id