feat: Export ID on Taxonomy#34143
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @ChrisChV! Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
requirements/edx/kernel.in
Outdated
There was a problem hiding this comment.
TODO: Bump version with openedx/openedx-core#145
ChrisChV
force-pushed
the
chris/FAL-3620-export-id-on-taxonomy
branch
2 times, most recently
from
3a1fa92 to
bb1d9c4
Compare
pomegranited
left a comment
pomegranited
left a comment
There was a problem hiding this comment.
@ChrisChV One nit, but 👍 once that's addressed.
- I tested this using the PR test instructions
- I read through the code
- I checked for accessibility issues by using my keyboard only during testing.
- Includes documentation
-
User-facing strings are extracted for translationN/A
| # Orphaned taxonomy | ||
| self.ot1 = Taxonomy.objects.create(name="ot1", enabled=True) | ||
| self.ot2 = Taxonomy.objects.create(name="ot2", enabled=False) | ||
| self.ot1 = Taxonomy.objects.create( |
There was a problem hiding this comment.
Could you please use the create_taxonomy API method to create these taxonomies?
|
Looks fine so far. I can approve and merge next week if the openedx-learning one is merged tomorrow. |
|
@ChrisChV 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
|
2U Release Notice: This PR has been deployed to the edX production environment. |
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
|
2U Release Notice: This PR has been deployed to the edX production environment. |
5 participants
Description
This adds the changes to support the new
export_Idfield onTaxonomy.Supporting information
Testing instructions
make requirementson cms shell to install the version of openedx-learning that useexport_id.make migrateon cms shell.Other information