fix: Upgrade edx-django-utils, dropping newrelic; fix test and typo#36799
Merged
fix: Upgrade edx-django-utils, dropping newrelic; fix test and typo#36799
Conversation
This upgrades edx-django-utils to a version that drops the newrelic
dependency. However, I also needed to fix a test that was sensitive to the
number of warnings that the code under test produced. With newrelic gone,
there's an additional warning.
- Fix test so that it isn't sensitive to unrelated warnings
- Fix typo in warning
For reference, this is the new warning:
```
"WARNING:edx_django_utils.monitoring.internal.backends:Could not load OPENEDX_TELEMETRY option 'edx_django_utils.monitoring.NewRelicBackend': Exception('Could not load New Relic monitoring backend; package not present.')"
```
This is expected due to edx-django-utils still defaulting to NR for
telemetry. (Perhaps the subject of a future breaking change.)
robrap
approved these changes
May 27, 2025
Contributor
|
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
Contributor
|
2U Release Notice: This PR has been deployed to the edX production environment. |
marlonkeating
pushed a commit
that referenced
this pull request
Jul 15, 2025
…36799) This upgrades edx-django-utils to a version that drops the newrelic dependency. However, I also needed to fix a test that was sensitive to the number of warnings that the code under test produced. With newrelic gone, there's an additional warning. - Fix test so that it isn't sensitive to unrelated warnings - Fix typo in warning For reference, this is the new warning: ``` "WARNING:edx_django_utils.monitoring.internal.backends:Could not load OPENEDX_TELEMETRY option 'edx_django_utils.monitoring.NewRelicBackend': Exception('Could not load New Relic monitoring backend; package not present.')" ``` This is expected due to edx-django-utils still defaulting to NR for telemetry. (Perhaps the subject of a future breaking change.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades edx-django-utils to a version that drops the newrelic dependency. However, I also needed to fix a test that was sensitive to the number of warnings that the code under test produced. With newrelic gone, there's an additional warning.
For reference, this is the new warning:
This is expected due to edx-django-utils still defaulting to NR for telemetry. (Perhaps the subject of a future breaking change.)