fix: allow periods in block_ids#38817
Merged
Merged
Conversation
Course -> Library import would previously fail if the block_id contained a period, but periods are legal in UsageKeys and can turn up, e.g. "good-vs.-evil" should be allowed. This is not *common* because most courses are edited in Studio and don't get descriptive block_ids. But OLX-edited courses can end up with block_ids like this.
ormsbee
force-pushed
the
fix-period-in-code
branch
from
8361f74 to
73f9964
Compare
Contributor
Author
|
@kdmccormick: Ready for your review. |
kdmccormick
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Course -> Library import would previously fail if the block_id contained
a period, but periods are legal in UsageKeys and can turn up, e.g.
"good-vs.-evil" should be allowed. This is not common because most
courses are edited in Studio and don't get descriptive block_ids. But
OLX-edited courses can end up with block_ids like this.