Skip to content

chore: Add references to docs to make relative, not direct, references#716

Merged
sarina merged 3 commits into
masterfrom
sarina/refs-cleanup
Jun 20, 2025
Merged

chore: Add references to docs to make relative, not direct, references#716
sarina merged 3 commits into
masterfrom
sarina/refs-cleanup

Conversation

@sarina

@sarina sarina commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

Usage of :doc: is an antipattern. It is fragile and prone to breaking cross references when docs are moved or renamed.

Adding in .. _reference: syntax to files and headings means cross-references can instead be made with the :ref: directive, which will (presuming the references themselves are not deleted or renamed) be more robust to docs refactorings.

@sarina

sarina commented Jun 8, 2025

Copy link
Copy Markdown
Contributor Author

Note to self: There are a few :doc: directives that need to be changed by additional PRs to docs.openedx.org and openedx-events/openedx-filters. That will be follow-on work.

@feanil feanil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inconsistencies in labeling but otherwise looks good.


.. Below is the display in the left sidebar on RTD. Please omit leading 0's

.. _OEP XXXX OEP Template:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why sphinx is not complaining about this, this label has been defined twice also it's only different from the label in oep-templates/adr-based-template.rst by one dash. Are these template files not processed by default or something?

@sarina sarina Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top-level oep-templates directory is not processed in the build, the top-level oeps directory is considered the source dir.

Comment thread oeps/architectural-decisions/oep-0004-arch-oauth-scopes.rst Outdated
Comment thread oeps/archived/oep-0002-bp-repo-metadata.rst Outdated
Comment thread oeps/archived/oep-0009-bp-permissions.rst Outdated
Comment thread oeps/architectural-decisions/oep-0032-arch-unique-identifier-for-users.rst Outdated
Comment thread oeps/archived/oep-0005-arch-containerize-devstack.rst Outdated
Comment thread oeps/archived/oep-0011-bp-FED-technology.rst Outdated
Comment thread oeps/archived/oep-0013.rst Outdated
Comment thread oeps/best-practices/oep-0017-bp-feature-toggles.rst Outdated
Comment thread oeps/processes/oep-0014-proc-archive-repos.rst Outdated
Comment thread oeps/architectural-decisions/oep-0052-arch-event-bus-architecture.rst Outdated
@sarina sarina force-pushed the sarina/refs-cleanup branch from 7610a37 to 6e04ccf Compare June 11, 2025 15:02
@sarina sarina force-pushed the sarina/refs-cleanup branch from 6e04ccf to 30a1cab Compare June 12, 2025 13:32
@sarina sarina requested a review from feanil June 12, 2025 13:33
@sarina

sarina commented Jun 16, 2025

Copy link
Copy Markdown
Contributor Author

@feanil anything else you'd like to see on this one?

@sarina sarina merged commit a744e81 into master Jun 20, 2025
5 checks passed
@sarina sarina deleted the sarina/refs-cleanup branch June 20, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants