build: support use as an npm workspace package - #4442
Open
arbrandes wants to merge 4 commits into
Open
Conversation
✅ Deploy Preview for paragon-openedx-v23 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-23.x #4442 +/- ##
=============================================
Coverage 94.25% 94.25%
=============================================
Files 242 242
Lines 4301 4301
Branches 992 1031 +39
=============================================
Hits 4054 4054
+ Misses 243 238 -5
- Partials 4 9 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Resolve babel from PATH, add clean and watch:build, and report 0.0.0-dev as the checked-in version. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/workspace-package-support
branch
2 times, most recently
from
September 2, 2026 19:37
2aeb09c to
2a7da1f
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/workspace-package-support
branch
2 times, most recently
from
September 2, 2026 21:42
159889a to
7496a5e
Compare
Co-Authored-By: Claude <noreply@anthropic.com>
Split the build into build-js and build-scss, the latter keyed on its scss and theme inputs, and point watch:build at the incremental target. Compiling the stylesheets takes minutes; the JavaScript takes seconds. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
arbrandes/workspace-package-support
branch
from
September 2, 2026 22:16
7496a5e to
e392b0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Paragon cannot currently be developed as a
packages/workspace of a site built onfrontend-base, which is howfrontend-baseand the MFEs themselves are developed. Three small things get in the way, all fixed here. Closes #4440.The
Makefilecalled./node_modules/.bin/babeldirectly, which does not exist under workspace hoisting. It now resolvesbabelfrom PATH, the way thetscline above it already does.A
cleantarget pluscleanandwatch:buildscripts givenpm run clean:packagesandnpm run dev:packagessomething to call, instead of silently no-opping for Paragon.The checked-in version becomes
0.0.0-dev, like every other Open edX frontend repo, leaving the real version to the release process.20.18.1onrelease-23.xis stale regardless, since semantic-release never commits the bump back.Compiling the stylesheets takes about three minutes here, against four seconds for everything else, so the build is now split into
build-jsandbuild-scss, with the latter keyed on its scss and theme inputs.buildstill cleans and does everything;watch:buildusesbuild-incremental, which skips the stylesheets unless they changed.LLM usage notice
Built with assistance from Claude.