fix: journal carries the OMS order ids — the money key (D6)#123
Merged
Conversation
The Assets Engine keys holds by omsOrderId (holds are placed before a cluster id exists), but the journal carried only cluster ids: settles and terminal releases would never have found their holds. JournalTrade gains takerOmsOrderId/makerOmsOrderId, JournalTerminal gains omsOrderId (both available at the existing hook sites); the bridge maps the OMS ids into the money commands. Documented consumer note on JournalTerminal: iceberg slices share the parent's omsOrderId, so a slice FILLED is not "the exposure is over" -- the AE suppresses feed releases for holds the OMS marks omsManagedRelease (companion assets-side change). Journal is dark; nothing recorded anywhere -- in-place schema edit. Determinism 67/0 unchanged; journal + retention + round-trip suites green. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code