Add Bitbucket federation docs, CI/CD reference, and pre-requisites to federation pages#420
Merged
alexellis merged 2 commits intoopenfaas:masterfrom Apr 2, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
Could you take a pass over the "Detailed Review" please? |
alexellis
reviewed
Mar 27, 2026
alexellis
reviewed
Mar 27, 2026
alexellis
reviewed
Mar 27, 2026
alexellis
reviewed
Mar 27, 2026
alexellis
reviewed
Mar 27, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…ages Add guide for Bitbucket Pipelines Web Identity Federation. All federation pages now document the faas-cli pro license requirement and how to configure it as a secret/variable in each CI provider. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
AI Pull Request OverviewSummary
Approval rating (1-10)8 - Solid documentation with good consistency, but some outdated references in examples. Summary per fileSummary per file
Overall AssessmentThe PR successfully adds missing Bitbucket support to OpenFaaS IAM federation and CI/CD documentation. The new content follows the established patterns from GitHub and GitLab guides, maintaining consistency. License pre-requisites have been appropriately added across all federation docs. Minor updates to policies and workflows improve functionality. No security or correctness issues identified in the technical content. Detailed ReviewDetailed Reviewdocs/openfaas-pro/iam/bitbucket-federation.md
docs/reference/cicd/bitbucket.md
docs/openfaas-pro/iam/github-actions-federation.md
docs/openfaas-pro/iam/gitlab-federation.md
docs/openfaas-pro/iam/overview.md
mkdocs.yml
Potential Improvements
AI agent details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add Web Identity Federation guide for Bitbucket Pipelines, covering OIDC issuer setup, custom audience configuration, and example pipelines.
Add a CI/CD reference page for Bitbucket Pipelines with examples for building, pushing, and deploying functions.
Add a pre-requisites section to all federation pages (Bitbucket, GitHub Actions, GitLab) documenting the
faas-cli proCLI license requirement and how to configure it in each CI provider.Motivation and Context
Bitbucket Pipelines users had no documentation for deploying to OpenFaaS using OIDC federation or for setting up CI/CD pipelines. The
faas-cli proplugin now supports a CLI license for use in CI workflows, which needs to be documented across all federation guides.How Has This Been Tested?
Reviewed rendered markdown locally.
Types of changes
Checklist:
git commit -s