Incorrect line for type when looking up the typeIndex, when type is a substring

[d-jeffery]

Problem: incorrect type index return for asset when asset-category is given precedence in declaration.

Example:

Fix: update each method to do a full string match, not a prefix match.

language/pkg/js/util/line-numbers.ts

Line 23 in 7d0da9b

.findIndex((line: string) => line.trim().startsWith(`${extension ? "extend " : ""}type ${typeName}`)) + skipIndex

language/pkg/go/utils/line-numbers.go

Line 16 in 7d0da9b

return strings.HasPrefix(strings.TrimSpace(line), "type "+typeName)

language/pkg/java/src/main/java/dev/openfga/language/validation/Dsl.java

Line 50 in 7d0da9b

return findLine(line -> line.trim().startsWith("type " + typeName), skipIndex);

[d-jeffery]

This would also be present if the same logic is used for relations and conditions, where a prefix match is done.

Edit:

Easily replicated with model:

model
  schema 1.1
type user
type role
  relations
    define assigne: [user]
type asset-category
  relations
    define a1: [role#assignee]
type asset
  relations
    define a1: [role#assignee]

Fixed for validation by converting the startsWith to a match call with a more specific regex;

const getTypeLineNumber = (typeName: string, lines?: string[], skipIndex?: number) => {
  ...
  return lines.slice(skipIndex).findIndex((line: string) => line.trim().match(`type ${typeName}$`)) + skipIndex;
};

models-to-modules code here doesn't take an offendingRelation like the error generation during validation of regular models.