Group: Cleanup

[kylemcdonald]

Cleanup includes anything that needs to just be removed or rearranged/moved around without changing the syntax or semantics of openFrameworks. For example: comment removal, or moving definitions around.

This is a group of issues identified during Code Review 2012. Add any relevant issues to this group, and when they are all closed we will close this issue. If an issue fits this pattern, but is more significant or not a simple fix, please add it as a separate issue.

[ofZach]

these lines in ofPixels.h should be removed:

https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/graphics/ofPixels.h#L109-110

[ofTheo]

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/utils/ofConstants.h#L178

remove commented out ofIndexType typedef

[ofTheo]

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/utils/ofConstants.h#L292

OF_SERIAL_NO_DATA
OF_SERIAL_ERROR

should be moved to ofSerial.h

[ofZach]

ofRenderCollection's class should be in it's own .cpp file.

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/graphics/ofRendererCollection.h

[kylemcdonald]

ofMatrix4x4.h has a line that reads ofVec3f c = rotateZ 30º ofVec3f a around ofVec3f b and the degree symbol is an extended ASCII character, which should be removed.

[ofZach]

could ofRenderCollection::draw(ofImage & img) be templated?

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/graphics/ofRendererCollection.h#L57-74

[kylemcdonald]

there's a random line in ofMatrix4x4.h that says AARON METHOD without explanation that should be removed.

[ofZach]

should only have one implementation of translate and setColor. wrapping happens at ofTranslate level:

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/graphics/ofRendererCollection.h

[jvcleave]

Move comment to next line
https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/app/ofAppRunner.h#L15

[danomatika]

The ofGetGlInternalFormat, ofGetGlFormatAndType, & ofGetImageTypeFromGLType functions in ofTexture could be static since they don't appear to change any internal data.

[ofTheo]

move static SimplexNoise1234 data to .cpp

https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/utils/ofNoise.h#L54

[damian0815]

O/C: ofVec4f operator+/+=/-/-= etc could be ordered more nicely

[NickHardeman]

ofNode getGlobalScale has some commented out code that should be removed
https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/3d/ofNode.cpp#L305-308

[NickHardeman]

Comments should be updated to reflect names of classes
ofBaseSoundInput
https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/types/ofBaseTypes.h#L126

ofBaseSoundOutput
https://github.com/openframeworks/openFrameworks/blob/develop/libs/openFrameworks/types/ofBaseTypes.h#L145

[danomatika]

This comment in ofTexture refers to immediate mode. Are we still using intermediate mode in this case anymore?