Skip to content

update linearResampleTo() and hermiteResampleTo() in ofSoundBuffer class.#7062

Open
sadmb wants to merge 1 commit intoopenframeworks:masterfrom
sadmb:soundbuffer_resampling_update
Open

update linearResampleTo() and hermiteResampleTo() in ofSoundBuffer class.#7062
sadmb wants to merge 1 commit intoopenframeworks:masterfrom
sadmb:soundbuffer_resampling_update

Conversation

@sadmb
Copy link
Contributor

@sadmb sadmb commented Aug 28, 2022

update resampling code in order to fix the following bugs.

  1. They were crashed when end had negative number.
  2. They only had 2 loops with high speed resampling

screenshot 2022-08-28 22 12 31

.

… following bugs.

1. They were crashed when end has negative number.
2. They only had 2 loops with high speed resampling.
@dimitre
Copy link
Member

dimitre commented Aug 28, 2022

Ping @roymacdonald

@danoli3
Copy link
Member

danoli3 commented Aug 29, 2022 via email

@roymacdonald
Copy link
Contributor

OF uses signed floats between -1 and 1.
I would rather use an external library to deal with resampling as it is non trivial. I made an addon using libsamplerate which can be ported to all platforms and it gives me correct results all the time, while the of implementation fails often. I would love to see such implemented. If you give me the gonI would be happy to implement for all platforms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants