ofxSvg::fixSvgString(): addition to xml preprocessor#7679
Merged
ofTheo merged 2 commits intoopenframeworks:masterfrom Sep 28, 2023
Merged
ofxSvg::fixSvgString(): addition to xml preprocessor#7679ofTheo merged 2 commits intoopenframeworks:masterfrom
ofTheo merged 2 commits intoopenframeworks:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affinity designer exports "flattened" SVG like this:
this % approach throws of svgtiny and it generates all vertices at (0, 0).
as a reference, the tiger.svg:
the proposed addition "fixes" this by: (1) checking if a viewBox is defined and (2) checking if width and height are set to 100%. if so, it replaces the 100%'s with the viewBox corresponding values.
(in other words, it should not be a breaking change as an SVG that has width/height defined as values with not be affected, and an SVG without them (or as %) would not work).
It emits warning when operating.
it also makes fixSvgString() static and public, this is to allow it's use outside of an instance, making it possible to slip into a preprocessing step in ofxSvgLoader(). (note that the method was already processing an inout string reference without accessing any member variables, so was not and instance method per se).