Better vscode json#7694
Merged
dimitre merged 3 commits intoopenframeworks:masterfrom Oct 5, 2023
Merged
Conversation
5 tasks
oxillo
reviewed
Oct 3, 2023
Contributor
There was a problem hiding this comment.
This configuration assumes that the project is given location compared to OF_ROOT.
I would rather have an OF_ROOT in the env part that indicates the location of OF relative to the project. That would also make the generation of the template easier.
I would also change the order of OF_LIBS_ROOT and OF_INCLUDE so OF_INCLUDE can depend of OF_LIBS_ROOT
{
" env" : {
"OF_ROOT" : "${workspaceFolder}/../../..",
"OF_LIBS_ROOT":"${OF_ROOT}/libs",
"OF_INCLUDE":["${OF_LIBS_ROOT}/openFrameworks/**"],
For MSYS2 configuration, it is still refering MINGW32...
Let's call it MINGW64 instead of Win32 so people can duplicate it for UCRT64 or else
Having "c:/msys64/mingw64/include/**" in includePath is enough and will include all libs such as cairo, glew,...
Compilerpath shall also be "c:/msys64/ming64/bin/g++.exe"
Member
Author
There was a problem hiding this comment.
Member
Author
|
👍
Feel free to. 🙂
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #7677 this updates the vscode json file to do better code completion and have the VS Code syntax highlighting match make.