Skip to content

Better vscode json#7694

Merged
dimitre merged 3 commits intoopenframeworks:masterfrom
ofTheo:better-vscode-json
Oct 5, 2023
Merged

Better vscode json#7694
dimitre merged 3 commits intoopenframeworks:masterfrom
ofTheo:better-vscode-json

Conversation

@ofTheo
Copy link
Copy Markdown
Member

@ofTheo ofTheo commented Oct 3, 2023

As discussed in #7677 this updates the vscode json file to do better code completion and have the VS Code syntax highlighting match make.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration assumes that the project is given location compared to OF_ROOT.
I would rather have an OF_ROOT in the env part that indicates the location of OF relative to the project. That would also make the generation of the template easier.
I would also change the order of OF_LIBS_ROOT and OF_INCLUDE so OF_INCLUDE can depend of OF_LIBS_ROOT

{
  " env" : {
       "OF_ROOT" : "${workspaceFolder}/../../..",
       "OF_LIBS_ROOT":"${OF_ROOT}/libs",
       "OF_INCLUDE":["${OF_LIBS_ROOT}/openFrameworks/**"],

For MSYS2 configuration, it is still refering MINGW32...
Let's call it MINGW64 instead of Win32 so people can duplicate it for UCRT64 or else
Having "c:/msys64/mingw64/include/**" in includePath is enough and will include all libs such as cairo, glew,...
Compilerpath shall also be "c:/msys64/ming64/bin/g++.exe"

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @oxillo that all sounds like great suggestions and actually will make it easier for @dimitre as he's working on getting proper PG support. So this way he would just need to update OF_ROOT if its not in the default location and the rest will work.

Will make these changes.
Thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to merge?

@ofTheo
Copy link
Copy Markdown
Member Author

ofTheo commented Oct 4, 2023 via email

@dimitre dimitre merged commit a0e69a0 into openframeworks:master Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants