Encirclement does not work on map edges

[Vectorial1024]

Describe the bug
So far I am aware of this strategy/feature "encirclement": if player A's land fully surrounds player B's land (NPC or not), then player B instantly loses and the land becomes owned by player A.

However, this does not work on map edges.

To Reproduce
Steps to reproduce the behavior:

1. Start near map edge (Player A)
2. Find a player that is at the map edge (Player B)
3. Surround Player B
4. No encirclement is triggered

Expected behavior
Encirclement should occur and Player B loses.

Screenshots
(Not screenshot, but an illustration of the situation.)

Consider this hypothetical scenario, where the colors are:

• White: unowned/neutral
• Red: Player A
• Blue: Player B
• Black: out-of-bounds area / map edge

Then, Player A should have encircled Player B, and Player B should lose.

Desktop (please complete the following information):

• OS: Windows
• Browser: Firefox
• Version 152

Additional context

It may be a good idea to also check lake-side / ocean-side encirclement, to ensure encirclement still works as expected.

Assignment

• I'd like to be assigned to this issue and work on it myself

[github-actions]

Hi @Vectorial1024, thanks for opening this issue. It hasn't been approved by a maintainer yet — we'll get back to you shortly to either milestone it (approval) or close it.

— Automated. See CONTRIBUTING.md.

[evanpelle]

This is intentional, but we can consider changing the behavior. We'll need to run playtests and see how it plays first.