have mirv attack enemy units

[evanpelle]

Description:

Have MIRVs first target enemy units.

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory
• I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
• I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

evan

[coderabbitai]

Walkthrough

The update refines MIRV execution by requiring the target to always be a Player, handling invalid targets with warnings and early deactivation. The proximity checking method is renamed for clarity. The warhead targeting logic is expanded to include more unit types, with improved validation and logging for edge cases.

Changes

File(s)	Change Summary
src/core/execution/MIRVExecution.ts	Enforces targetPlayer as Player, adds validation and warnings for invalid targets, renames proximity check method, and expands warhead targeting logic to include additional unit types.

Sequence Diagram(s)

sequenceDiagram
    participant MIRVExecution
    participant GameLogger
    participant Player
    participant Tile

    MIRVExecution->Tile: Get owner of target tile
    alt Owner is Player
        MIRVExecution->Player: Set as targetPlayer
    else Owner is not Player
        MIRVExecution->GameLogger: Log warning
        MIRVExecution->MIRVExecution: Deactivate execution
    end

    MIRVExecution->Player: Get all units
    loop For each unit
        alt Unit is not TradeShip or nuke-type
            MIRVExecution->MIRVExecution: Check proximity to existing targets
            alt Not too close
                MIRVExecution->MIRVExecution: Add as warhead target
            end
        end
    end

    alt No warheads added
        MIRVExecution->GameLogger: Log warning
        MIRVExecution->MIRVExecution: Deactivate execution
    end

Loading

Possibly related PRs

• Fix mirvhead spamming same location #801: Introduced and used the proximity check method that is now renamed and extended in this PR.

Suggested labels

Bug Fix

Poem

MIRVs now fly with purpose clear,
Only at Players, no strangers near.
Proximity checked with a brand new name,
Warnings logged if none to claim.
Warheads seek out units anew—
Code is sharper, and safer too!
💥

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-13T20_35_39_666Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8c1bc0f and 15bcd9d.

📒 Files selected for processing (1)

• src/core/execution/MIRVExecution.ts (7 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/core/execution/MIRVExecution.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.