Skip to content

Fix a river in Balkans not connecting to the sea - #4249

Merged
evanpelle merged 1 commit into
openfrontio:mainfrom
RickD004:fixbalkans
Jun 12, 2026
Merged

Fix a river in Balkans not connecting to the sea#4249
evanpelle merged 1 commit into
openfrontio:mainfrom
RickD004:fixbalkans

Conversation

@RickD004

Copy link
Copy Markdown
Contributor

Resolves #4248

Description:

Fix river not connected in Balkans map along the map border. The map generator accidentally deleted some columns of pixels along the map limits, and it disconnected a river.

image

Updated version

image

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6670def0-0759-4332-9194-800e5a4efd01

📥 Commits

Reviewing files that changed from the base of the PR and between b85d1fc and 0b2c98c.

⛔ Files ignored due to path filters (4)
  • map-generator/assets/maps/balkans/image.png is excluded by !**/*.png
  • resources/maps/balkans/map.bin is excluded by !**/*.bin
  • resources/maps/balkans/map16x.bin is excluded by !**/*.bin
  • resources/maps/balkans/map4x.bin is excluded by !**/*.bin
📒 Files selected for processing (2)
  • resources/maps/balkans/manifest.json
  • resources/maps/balkans/thumbnail.webp

Walkthrough

Updated num_land_tiles values for the Balkans map across three resolution tiers (map, map16x, map4x) in the manifest file. No structural changes or other fields were modified.

Changes

Balkans Map Land Tile Updates

Layer / File(s) Summary
Land tile count adjustments
resources/maps/balkans/manifest.json
Three num_land_tiles values updated across map resolution tiers (2048x2048, 512x512, 1024x1024) while preserving dimension fields and manifest structure.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openfrontio/OpenFrontIO#4139: Both PRs directly update resources/maps/**/manifest.json by changing the num_land_tiles counts for the map, map16x, and map4x tiers.
  • openfrontio/OpenFrontIO#3998: Both PRs directly modify the Balkans map's resources/maps/balkans/manifest.json map metadata—main PR adjusts num_land_tiles values, while the retrieved PR adds the Balkans manifest (including that same metadata structure).

Suggested labels

approved

Suggested reviewers

  • evanpelle

Poem

🗺️ The river flows, now whole and true,
Where tiles once missed connect anew,
Three resolutions, counts refined,
A map corrected, borders aligned. 🌊

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The linked issue #4248 requires fixing a river not connected in the Balkans map. The PR updates manifest.json num_land_tiles values, but the actual pixel fix for the river is in ignored binary files (map.bin, map16x.bin, map4x.bin) excluded from review. Cannot verify the pixel-level river fix since the binary map files (map.bin, map16x.bin, map4x.bin) were excluded by path filters. The manifest updates are present but incomplete evidence of the complete fix.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: fixing a river connection issue in the Balkans map.
Description check ✅ Passed The description is directly related to the changeset, explaining the river connection issue and referencing the linked issue.
Out of Scope Changes check ✅ Passed The manifest.json changes directly relate to the stated objective of fixing the Balkans map river issue, with no out-of-scope modifications detected.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanpelle
evanpelle merged commit 32011d2 into openfrontio:main Jun 12, 2026
12 of 14 checks passed
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Jun 12, 2026
@RickD004
RickD004 deleted the fixbalkans branch June 12, 2026 22:22
@coderabbitai coderabbitai Bot mentioned this pull request Aug 8, 2026
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

Fix river not connected in Balkans map

2 participants