Multiple terrain changes and fixes for maps

[RickD004]

Description:

Multiple changes for maps:

Mississippi - Fix some landlocked lakes, near the main coast. Players would sometimes accidentally put a port in the dead lakes

North America - Re-add the Azores and Cape verde (accidentally removed when the map generator got updated to delete small islands)

Africa - Re-add Ascencion and Saint Helena Islands, same case as NA

Danish Straits - replace german empire flag , as agreed in the leads channel

Giant World Map - Coast fixes, including adding Suez Canal which greatly affected trade routes

Great Lakes - fix landlocked lake

Two Lakes - New Terrain combining both old and recent versions

World - Add strait of malacca

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

tri.star1011

[coderabbitai]

Walkthrough

This PR updates map data files for OpenFrontIO. It adds new nation entries (Saint Helena, Canary Islands, Cyprus, Comoros, Mayotte, Ascension Island, Equatorial Guinea, Sao Tome and Principe to Africa; Cabo Verde and Azores to North America), renames "German Empire" flag to "German Confederation" for Danish Straits nations, adds new country records to countries.json, lowers TwoLakes multiplayer_frequency from 6 to 4, and adjusts precomputed land-tile counts across several map manifests.

Changes

Map Data Updates

Layer / File(s)	Summary
TwoLakes multiplayer frequency and tile counts map-generator/assets/maps/twolakes/info.json, resources/maps/twolakes/manifest.json, src/core/game/Maps.gen.ts	Lowers TwoLakes multiplayer_frequency from 6 to 4 and updates land-tile counts.
New Africa nations map-generator/assets/maps/africa/info.json, resources/maps/africa/manifest.json	Adds Saint Helena, Canary Islands, Cyprus, Comoros, Mayotte, Ascension Island, Equatorial Guinea, and Sao Tome and Principe nation entries, and bumps the manifest's num_land_tiles.
Danish Straits flag rename map-generator/assets/maps/danishstraits/info.json, resources/maps/danishstraits/manifest.json, resources/countries.json	Renames "German Empire" flags to "German Confederation" for Mecklenburg-Schwerin, Oldenburg, and Hamburg entries, and adds a "German Confederation" country record.
North America Cabo Verde and Azores nations map-generator/assets/maps/northamerica/info.json, resources/maps/northamerica/manifest.json, resources/countries.json	Adds Cabo Verde and Azores nation entries, updates land-tile count, and adds an Azores country record.
Antarctica country entries resources/countries.json	Adds "Antarctica", "Antarctica (True South)", and "British Antarctic Territory" country records.
Land-tile count updates for other maps resources/maps/giantworldmap/manifest.json, resources/maps/greatlakes/manifest.json, resources/maps/mississippiriver/manifest.json, resources/maps/world/manifest.json	Adjusts num_land_tiles values for map, map16x, and map4x variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4139: Both PRs touch resources/maps/twolakes/manifest.json by updating the num_land_tiles metadata for the TwoLakes map.

Suggested labels: Feature

Suggested reviewers: evanpelle, FloPinguin

Poem

A rabbit hops the map anew,
Cabo Verde and Azores in view,
Flags renamed with careful care,
Tiles recounted, everywhere.
Antarctica joins the land parade,
Simple data, neatly made. 🐇🗺️

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title matches the main theme of map terrain fixes and related updates, though it is broad.
Description check	✅ Passed	The description is clearly related to the map changes in the PR and summarizes the affected maps.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[RickD004]

if v32 patches are still planned please do add this one in a patch, since it fixes gameplay affecting stuff like landlocked lakes and missing islands

[evanpelle]

thanks!