Adds Gulf of Guinea map#4590
Merged
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAdds the Gulf Of Guinea map with metadata, nation definitions, country entries, localization, a thumbnail, resource manifests, and runtime map registration. ChangesGulf Of Guinea map
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MapManifest
participant TranslationCatalog
participant MapsRegistry
MapManifest->>MapsRegistry: provide GulfOfGuinea metadata
TranslationCatalog->>MapsRegistry: provide map.gulfofguinea label
MapsRegistry->>MapsRegistry: register GulfOfGuinea
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@map-generator/assets/maps/gulfofguinea/info.json`:
- Around line 316-318: Update the place name in the map location entry
identified by the name “Fulenzem” to “Foulenzem”; leave its coordinates and flag
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 203bf7a0-12b0-4df1-8a5c-28dcb8bcbdf3
⛔ Files ignored due to path filters (11)
map-generator/assets/maps/gulfofguinea/image.pngis excluded by!**/*.pngresources/flags/Ambazonia.svgis excluded by!**/*.svgresources/flags/Biafra.svgis excluded by!**/*.svgresources/flags/Kingdom of Benin.svgis excluded by!**/*.svgresources/flags/Kingdom of Dahomey.svgis excluded by!**/*.svgresources/flags/Kingdom of Kongo.svgis excluded by!**/*.svgresources/flags/Mali Empire.svgis excluded by!**/*.svgresources/flags/gq-an.svgis excluded by!**/*.svgresources/maps/gulfofguinea/map.binis excluded by!**/*.binresources/maps/gulfofguinea/map16x.binis excluded by!**/*.binresources/maps/gulfofguinea/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (6)
map-generator/assets/maps/gulfofguinea/info.jsonresources/countries.jsonresources/lang/en.jsonresources/maps/gulfofguinea/manifest.jsonresources/maps/gulfofguinea/thumbnail.webpsrc/core/game/Maps.gen.ts
github-project-automation
Bot
moved this from Triage
to Development
in OpenFront Release Management
RickD004
added
the
Maps
evanpelle
approved these changes
Jul 13, 2026
github-project-automation
Bot
moved this from Development
to Final Review
in OpenFront Release Management
github-project-automation
Bot
moved this from Final Review
to Complete
in OpenFront Release Management
CanArslanDev
referenced
this pull request
in CanArslanDev/SkyFront
Jul 15, 2026
## Description: Adds Gulf of Guinea map to the game: https://en.wikipedia.org/wiki/Gulf_of_Guinea Final map of the "pirate maps" for v33 , alongside Irish Sea and Levant. The map is designed so that all the trade from the mainland, which covers 2 of the four corners of the "square" (inverse L) passes through 3 small islands, which although small in size they will super-boost pirates in that zone. The mainland is otherwise fairly lineal, playing like maps like Conakry. Also some sub-saharan african representation The map is decorated with Impassable terrain in its southern border, and has additional nations for Hvn and Solo games https://github.com/user-attachments/assets/9c9fd8c0-fefb-46c4-8720-55e90401681e ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: tri.star1011 (cherry picked from commit 558f2e20db0e0f51c0070f6db6db217fcdccdb87)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds Gulf of Guinea map to the game:
https://en.wikipedia.org/wiki/Gulf_of_Guinea
Final map of the "pirate maps" for v33 , alongside Irish Sea and Levant. The map is designed so that all the trade from the mainland, which covers 2 of the four corners of the "square" (inverse L) passes through 3 small islands, which although small in size they will super-boost pirates in that zone. The mainland is otherwise fairly lineal, playing like maps like Conakry.
Also some sub-saharan african representation
The map is decorated with Impassable terrain in its southern border, and has additional nations for Hvn and Solo games
Grabacion.de.pantalla.2026-07-12.203008.mp4
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
tri.star1011