Exempt the Electron desktop shell from loading Admiral ads

[Celant]

Add approved & assigned issue number here:

Description:

Admiral (src/client/Admiral.ts), OpenFront's ad-recovery vendor, is injected via a runtime document.createElement("script") call rather than a static HTML <script> tag. That makes it invisible to HTML-level ad stripping done in the (private, separate) Electron/Steam shell repo, so it was attempting to load — and cascading into further ad-exchange calls — inside the paid desktop client.

Main.ts already exempts CrazyGames-hosted sessions from Admiral via window.adsEnabled = !isAdFree && !crazyGamesSDK.isOnCrazyGames(). This extends that same, existing gate to also cover the Electron desktop shell, detected via a new src/client/DesktopShell.ts (isDesktopShell()), which mirrors CrazyGamesSDK.ts's isOnCrazyGames() pattern: it checks for window.openfrontDesktop, a global only the Electron app's own preload script ever sets. No behavior change for web/CrazyGames users — the change is a single additional && clause.

Please complete the following:

• I have added screenshots for all UI updates — n/a, no UI change
• I process any text displayed to the user through translateText() and I've added it to the en.json file — n/a, no user-facing text added
• I have added relevant tests to the test directory — no unit test added; following existing convention in this area (CrazyGamesSDK.ts's isOnCrazyGames(), the pattern this mirrors, also has no dedicated unit test). Verified instead via tsc --noEmit, eslint/prettier, a full build-prod, and the Electron shell's own e2e network-isolation test confirming Admiral's script (and downstream ad-exchange calls) no longer attempt to load when window.openfrontDesktop is present.

Please put your Discord username so you can be contacted if a bug or regression is found:

jish

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f637fb49-8a7f-4af2-8227-4c1f7b815ccd

📥 Commits

Reviewing files that changed from the base of the PR and between 37e5b1b and ca9ea00.

📒 Files selected for processing (1)

• src/client/Main.ts

🚧 Files skipped from review as they are similar to previous changes (1)

• src/client/Main.ts

---

Walkthrough

Adds Electron desktop-shell detection and disables ads when the application runs inside that shell.

Changes

Desktop shell ad handling

Layer / File(s)	Summary
Desktop detection and ad gating src/client/DesktopShell.ts, src/client/Main.ts	Declares the desktop preload global, exports isDesktopShell(), and requires the runtime to be outside the desktop shell before enabling ads.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4534: Uses window.adsEnabled in the same ad-loading and gatekeeper flow.

Poem

A desktop shell now marks its place,
Ads step back with quiet grace.
A preload sign, a simple check,
Keeps the ad flow on the right deck.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: blocking Admiral ads in the Electron desktop shell.
Description check	✅ Passed	The description is directly related to the code changes and explains the desktop-shell ad exemption clearly.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[iiamlewis]

Yes