Adds Map of the Finger Lakes

[crunchybbb2]

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #4674 (issue number)

Description:

Adds Map of the Finger Lakes in upstate New York

• 10 town based nations (No additional nations)
• Land Area 1.82 million
• Contains many thick rivers and streams connecting the lakes to one main river
• ignore the disconected rivers in screenshot, they were fixed

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME crunchybbbbb

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3abd4650-e645-471f-8dfc-1b001b6f16e5

📥 Commits

Reviewing files that changed from the base of the PR and between 8ad0a78 and 9ee7df7.

📒 Files selected for processing (1)

• src/core/game/Maps.gen.ts

---

Walkthrough

Adds the Finger Lakes map with metadata, ten location entries, map assets, English localization, and registration in the game’s map enum and registry.

Changes

Finger Lakes map

Layer / File(s)	Summary
Map resources and metadata map-generator/assets/maps/fingerlakes/info.json, resources/maps/fingerlakes/manifest.json, resources/lang/en.json, resources/maps/fingerlakes/thumbnail.webp	Defines the map metadata, dimensions, categories, locations, localization entry, and thumbnail.
Map type and registry entry src/core/game/Maps.gen.ts	Adds GameMapType.FingerLakes and its MapInfo registry entry.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• openfrontio/OpenFrontIO#4678: Adds another map through the same registry, localization, and metadata paths.
• openfrontio/OpenFrontIO#4546: Adds a map registry entry and matching localization.
• openfrontio/OpenFrontIO#4456: Adds a new map enum member and registry entry.

Suggested labels: Maps

Suggested reviewers: rickd004, flopinguin, evanpelle

Poem

Finger Lakes joins the map,
With towns and shores along its track.
New York finds a place to play,
With lakes and rivers on display.
The registry opens wide—
A new adventure waits inside.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	The PR clearly adds Finger Lakes map assets, but the summary does not confirm the exact nation count, land area, or river layout requirements.	Verify the map contains exactly 10 town-based nations, the 1.82 million land area, and the intended river connections.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: adding the Finger Lakes map.
Description check	✅ Passed	The description is directly related to the Finger Lakes map additions.
Out of Scope Changes check	✅ Passed	The changed files are all part of adding the new Finger Lakes map and its localization.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Maps.gen.ts`:
- Line 45: Update the existing generic core registry-invariant test for the Maps
registry to cover enum entries, translation keys, categories, and frequency
alignment after adding FingerLakes. Reuse the established non-per-map registry
assertions rather than adding a Finger Lakes-specific case, and ensure the test
covers the generated Maps registry symbols affected by this change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4af16beb-24e6-40ed-8ea1-1be8df07c9f9

📥 Commits

Reviewing files that changed from the base of the PR and between d76a0c4 and 8ad0a78.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/fingerlakes/image.png is excluded by !**/*.png
• resources/maps/fingerlakes/map.bin is excluded by !**/*.bin
• resources/maps/fingerlakes/map16x.bin is excluded by !**/*.bin
• resources/maps/fingerlakes/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (5)

• map-generator/assets/maps/fingerlakes/info.json
• resources/lang/en.json
• resources/maps/fingerlakes/manifest.json
• resources/maps/fingerlakes/thumbnail.webp
• src/core/game/Maps.gen.ts