feat(ranked): explain clan/friend pairing on the ranked mode screen (port of #4861 to main) - #4862
Conversation
…4861) ## What Adds a note under the cards on the ranked mode select screen: > In team modes, clanmates and friends in the queue are placed on the same team where possible. Friends are paired first, then clanmates. If your ratings are too far apart you'll be matched separately to keep games fair. ## Why Players had no way to know that queuing with a clanmate or friend is *meant* to put them on the same team, or why it sometimes doesn't. The matchmaking side of this is openfrontio/infra#495, which makes clan/friend pairs a first-class grouping key ahead of ELO selection — this explains the resulting behaviour, including the rating gap past which a pair is deliberately split. Worded for **team modes generally** rather than 2v2 specifically, so it still reads correctly as more team gamemodes are added. ## Notes - New `mode_selector.ranked_pairing_note` key in `en.json` only — Crowdin owns the other locales. - The note deliberately does not quote the ELO threshold. That value lives in the matchmaking API, a separate repo the client cannot import from, so any client-side literal would silently go stale when the matchmaker is retuned — and the repo has a standing convention against hardcoding API-owned values (`TribesPanel.ts:363`). Describing the rule qualitatively keeps the threshold in one place. - `translateText` uses `IntlMessageFormat`, where apostrophes are escape characters and the string contains "you'll" — verified the message renders and interpolates correctly rather than assuming. ## Testing - `tsc --noEmit` clean, eslint clean, prettier clean. - Client suite: 225 files, 2594 tests, all passing. Targets `v33` rather than `main`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit 72b1861)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
WalkthroughThe ranked modal now shows a translated note below the ranked mode cards. The note explains friend and clanmate pairing priority and rating-based separation. ChangesRanked pairing guidance
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Port of #4861, which merged into
v33, so the change isn't lost on the next release cut.Straight
git cherry-pick -xof72b1861ec— no conflicts, and the resultingRankedModal.tsanden.jsonare byte-identical to thev33versions.What
Adds a note under the cards on the ranked mode select screen:
Worded for team modes generally rather than 2v2 specifically, so it still reads correctly as more team gamemodes are added. It deliberately doesn't quote the ELO threshold — that value lives in the matchmaking API, a separate repo the client can't import from, so any client-side literal would silently go stale when the matchmaker is retuned.
New
mode_selector.ranked_pairing_notekey inen.jsononly; Crowdin owns the other locales.Testing
tsc --noEmitclean, prettier clean, againstmain's tree rather than just assuming thev33result carries over.Note
The matchmaking change this describes is openfrontio/infra#495, which is still open. Until it merges and deploys, this note describes pairing behaviour the API doesn't implement yet.
🤖 Generated with Claude Code