Skip to content

prevent translation keys from appearing in the Streaming Now panel - #4870

Merged
evanpelle merged 1 commit into
openfrontio:v33from
Aotumuri:fix-translation-stream
Aug 6, 2026
Merged

prevent translation keys from appearing in the Streaming Now panel#4870
evanpelle merged 1 commit into
openfrontio:v33from
Aotumuri:fix-translation-stream

Conversation

@Aotumuri

@Aotumuri Aotumuri commented Aug 4, 2026

Copy link
Copy Markdown
Member

Description:

This PR addresses an issue reported in the translation server where the Streaming Now panel temporarily displayed translation keys when using a language other than English.

The streaming-now component was not refreshed after translations finished loading, so the correct strings did not appear until the next stream refresh.

before
スクリーンショット 2026-08-05 6 58 23

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

The language selector now refreshes the streaming-now component when translations are applied.

Changes

Translation refresh

Layer / File(s) Summary
Streaming component refresh
src/client/LangSelector.ts
The translation-triggered update list now includes streaming-now.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: ryanbarlow97

Poem

New words flow bright,
Streaming status joins the call,
Language blooms anew.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the fix for translation keys appearing in the Streaming Now panel.
Description check ✅ Passed The description directly explains the Streaming Now translation issue and the component refresh fix.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management Aug 6, 2026
@evanpelle evanpelle added this to the v33 milestone Aug 6, 2026
@evanpelle
evanpelle merged commit 43e7ee9 into openfrontio:v33 Aug 6, 2026
12 of 14 checks passed
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Aug 6, 2026
evanpelle pushed a commit that referenced this pull request Aug 6, 2026
…4870)

## Description:

This PR addresses an issue reported in the translation server where the
Streaming Now panel temporarily displayed translation keys when using a
language other than English.

The `streaming-now` component was not refreshed after translations
finished loading, so the correct strings did not appear until the next
stream refresh.

before
<img width="323" height="152" alt="スクリーンショット 2026-08-05 6 58 23"
src="https://github.com/user-attachments/assets/d69ec43b-fab6-44e5-bb7e-cd58ff94d735"
/>

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory

## Please put your Discord username so you can be contacted if a bug or
regression is found:

aotumuri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants