fix(i18n): add missing multi_tab translation keys to en.json - #4923
fix(i18n): add missing multi_tab translation keys to en.json#4923berkelmali wants to merge 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdded English translations for the multi-tab modal. Added a Vitest test that verifies the expected translation keys and values. ChangesMulti-tab localization
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@berkelmali looks like prettier is failing |
|
Formatted ests/client/MultiTabModal.test.ts to comply with Prettier max printWidth (80 chars). All tests (EnJsonSorted.test.ts, MultiTabModal.test.ts) and Prettier formatting checks are now passing. |
PR 4:
fix(i18n): add missing multi_tab translation keys to en.jsonDescription:
The multi-tab warning modal (
MultiTabModal.ts) renders copy usingtranslateText()calls for themulti_tab.*namespace (multi_tab.warning,multi_tab.detected,multi_tab.please_wait,multi_tab.seconds,multi_tab.explanation).However, the
multi_tabkey section was missing fromresources/lang/en.json, causing the modal to render raw translation keys on-screen instead of localized text.This PR adds the missing
multi_tabtranslation key object toresources/lang/en.jsonin alphabetical order, resolving the modal's copy and satisfyingEnJsonSorted.test.ts.Please complete the following:
tests/client/MultiTabModal.test.ts)Please put your Discord username so you can be contacted if a bug or regression is found:
barfires