Skip to content

fix(i18n): add missing multi_tab translation keys to en.json - #4923

Open
berkelmali wants to merge 2 commits into
openfrontio:mainfrom
berkelmali:fix/multi-tab-untranslated-keys
Open

fix(i18n): add missing multi_tab translation keys to en.json#4923
berkelmali wants to merge 2 commits into
openfrontio:mainfrom
berkelmali:fix/multi-tab-untranslated-keys

Conversation

@berkelmali

Copy link
Copy Markdown
Contributor

PR 4: fix(i18n): add missing multi_tab translation keys to en.json

Description:

The multi-tab warning modal (MultiTabModal.ts) renders copy using translateText() calls for the multi_tab.* namespace (multi_tab.warning, multi_tab.detected, multi_tab.please_wait, multi_tab.seconds, multi_tab.explanation).

However, the multi_tab key section was missing from resources/lang/en.json, causing the modal to render raw translation keys on-screen instead of localized text.

This PR adds the missing multi_tab translation key object to resources/lang/en.json in alphabetical order, resolving the modal's copy and satisfying EnJsonSorted.test.ts.

Please complete the following:

  • I have added screenshots for all UI updates (N/A — i18n text resolution)
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory (tests/client/MultiTabModal.test.ts)
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

barfires

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: cc5b04fd-a567-4643-832b-e7e2a06983dd

📥 Commits

Reviewing files that changed from the base of the PR and between 8e5c51c and 17034f2.

📒 Files selected for processing (1)
  • tests/client/MultiTabModal.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • tests/client/MultiTabModal.test.ts

Walkthrough

Added English translations for the multi-tab modal. Added a Vitest test that verifies the expected translation keys and values.

Changes

Multi-tab localization

Layer / File(s) Summary
Add and validate multi-tab translations
resources/lang/en.json, tests/client/MultiTabModal.test.ts
Added the multi_tab translation group for tab detection, the single-active-tab restriction, wait time, and warning text. Added a test for the expected keys and English values.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested labels: Translation

Poem

One tab stays bright,
While others wait in quiet light.
Strings guide the way,
Tests guard each phrase today.
Vigilant mode holds tight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the missing i18n keys added to en.json, which is the main change in the pull request.
Description check ✅ Passed The description explains the missing multi_tab translations, the affected modal, the test coverage, and the expected result.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the small-fix Small fix (≤ 50 lines) — auto-applied by PR gate label Aug 9, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes Aug 9, 2026
@ryanbarlow97

Copy link
Copy Markdown
Contributor

@berkelmali looks like prettier is failing

@berkelmali

Copy link
Copy Markdown
Contributor Author

Formatted ests/client/MultiTabModal.test.ts to comply with Prettier max printWidth (80 chars). All tests (EnJsonSorted.test.ts, MultiTabModal.test.ts) and Prettier formatting checks are now passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

small-fix Small fix (≤ 50 lines) — auto-applied by PR gate

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

2 participants