Conversation
Contributor
|
I realise this is a fairly chunky patch. It touches every path I could find that might trigger a map update, so it was never going to be a dainty little thing. If you spot any obvious regressions, whether they are mine or something that crept in while trunk shifted under the original PR during review, I’m happy to help chase them down. |
Collaborator
Author
|
We are going to back this out for 4.27 but get it into 4.28 beta as the first PR. It looks like there are a couple of issues that are surmountable but we need to get 4.27 out and don't want to give this the time it needs to soak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.