Let the backend handle movies - #27
Merged
Merged
Conversation
NASA took down the server and host that provided the movies HC could play. HC just opened a brower tab. We should remove the dependency of the movie server from HC and let the backend figure it out. This keeps the filenames essentially the same but sends the browser to the backend which can serve up movies, redirect, or whatever.
We observed the NASA page was down for a while. HamClock shouldn't bake this URL into its code. It should direct its request to the backend. The movie is a YouTube video so that backend could fall back to the YouTube URL if the NASA page is down.
Keeping in the spirit of using the configured port, these URLs need to point to the backend without https. The backend probably supports https for f/w upgrades but we'll follow the standard of all the other endpoints
This PR has been sitting here since we started developing on HamClock. As the PR was originally written it creates a backward compatiblity problem with backends that don't implement the new endpoint. This PR falls back to the original method if the backend doesn't support the endpoint, thereby making it backward compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NASA took down the server and host that provided the movies HC could play. HC just opened a brower tab. We should remove the dependency of the movie server from HC and let the backend figure it out. This keeps the filenames essentially the same but sends the browser to the backend which can serve up movies, redirect, or whatever.