Modernize plasma tests and fix CI workflow permissions#2318
Merged
adrianreber merged 5 commits intoopenhpc:4.xfrom Jan 5, 2026
Merged
Modernize plasma tests and fix CI workflow permissions#2318adrianreber merged 5 commits intoopenhpc:4.xfrom
adrianreber merged 5 commits intoopenhpc:4.xfrom
Conversation
Member
adrianreber
commented
Jan 5, 2026
adrianreber
commented
- Modernize plasma test framework to match other OpenHPC library tests
- Fix printf format argument mismatch in plasma test (GitHub code scanning)
- Update plasma configure.ac to modern autoconf syntax via autoupdate
- Add explicit permissions to GitHub Action workflows (GitHub code scanning)
- Bump factory version to 4.1
Update configure.ac to modern autoconf syntax using autoupdate: - Update AC_PREREQ from 2.59 to 2.71 - Use proper quoting for AC_INIT arguments - Replace deprecated AC_ERROR with AC_MSG_ERROR - Remove empty parentheses from AC_OUTPUT 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Adrian Reber <areber@redhat.com>
Add missing fourth argument to printf call in print_main_usage(). The format string contains four %s specifiers but only three arguments were provided. Fixes "Too few arguments to formatting function" as reported by GitHub code scanning. 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Adrian Reber <areber@redhat.com>
Modernize the plasma test infrastructure to match patterns used by
other OpenHPC library tests:
- Update source paths from ./common/ to ../../../common/
- Add setup_file() function for test initialization with proper
variable exports (NODES, TASKS, ARGS, TIMEOUT, TESTNAME)
- Use ${RESOURCE_MANAGER} instead of local $RM variable
- Add timeout support with -t flag for run_serial_binary
- Enable parallel test execution with -j flag in shebang
- Use setup()/teardown() for temp file handling in test_module
- Use get_rpm_name helper instead of hardcoded rpm name
- Apply proper quoting throughout for shellcheck compliance
- Remove trailing cleanup code in favor of teardown function
🤖 Generated with [Claude Code](https://claude.ai/code)
Signed-off-by: Adrian Reber <areber@redhat.com>
Signed-off-by: Adrian Reber <areber@redhat.com>
Add permissions blocks to workflows that were missing them to fix "Workflow does not contain permissions" warnings from GitHub code scanning. - lint.yml: contents read only - stale.yml: contents read, issues and pull-requests write - validate.yml: contents read only 🤖 Generated with [Claude Code](https://claude.ai/code) Signed-off-by: Adrian Reber <areber@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.