Modernize papi test framework and update spec for package checker#2328
Merged
adrianreber merged 10 commits intoopenhpc:4.xfrom Jan 11, 2026
Merged
Modernize papi test framework and update spec for package checker#2328adrianreber merged 10 commits intoopenhpc:4.xfrom
adrianreber merged 10 commits intoopenhpc:4.xfrom
Conversation
Member
adrianreber
commented
Jan 11, 2026
- Update papi spec to use GitHub releases URL for compatibility with OpenHPC package update checker
- Add BEST_PRACTICES.md documenting test framework guidelines
- Modernize papi tests following the new best practices (BATS parallel execution, proper variable quoting, setup_file/teardown, SIMPLE_CI handling)
- Add upstream smoke tests (simple.c, threads.c) from PAPI repository
- Reformat papi C test files with clang-format
- Run autoupdate on configure.ac files
Update source URL to use GitHub releases endpoint which is compatible with OpenHPC's package update checker. Also simplify BuildRequires by removing SUSE-specific conditionals. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
Apply clang-format to all papi test C files to follow the coding style used in tests/. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
Document best practices for writing tests in the tests/ directory, covering BATS framework usage, shell variable quoting, SIMPLE_CI environment handling, and CI lint integration. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
Add simple.c and threads.c smoke tests from upstream PAPI repository: https://github.com/icl-utk-edu/papi/tree/master/src/smoke_tests These tests validate basic PAPI functionality and multithreaded usage. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
Update papi test infrastructure to follow patterns from BEST_PRACTICES.md:
- Add parallel execution flag to BATS shebang
- Update source paths to use ../../../common/
- Add setup_file() for variable initialization
- Add setup()/teardown() for temp file handling
- Use ${RESOURCE_MANAGER} instead of local aliases
- Quote all variables with curly braces
- Add SIMPLE_CI skip for tests requiring real hardware
- Add timeout support to run_serial_binary calls
- Use run_with_retry for flaky branches test
- Add papi tests to CI lint targets
- Include new smoke tests in Makefile.am and rm_execution
Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: Adrian Reber <areber@redhat.com>
Run autoupdate to modernize autoconf macros in configure.ac files. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
📦 Package Count Analysis ResultsEnvironment: UBI 10 Container 🏭 Factory RepositoriesStatus: ✅ Factory repositories analysis completed successfully
Analysis performed by OpenHPC Package Count CI |
🚀 CCache Statistics
📊 Detailed StatisticsopenEuler (aarch64)openEuler (x86_64)RHEL (aarch64/gnu15)RHEL (x86_64/gnu15)RHEL (x86_64/intel)🤖 Generated from workflow run |
Signed-off-by: Adrian Reber <areber@redhat.com>
Keep libpapi.a as tau explicitly requires it. Remove the spec code that deleted static libraries and update test to not check for their absence. Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
Apply best practices to native_avail test: - Add parallel execution flag to BATS shebang - Update source paths to use ../../../common/ - Add setup_file() for variable initialization - Fix testname to perf-tools/papi - Quote all variables with curly braces Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
4d7a7ea to
76a649a
Compare
- Skip tests requiring hardware counters on aarch64 in SIMPLE_CI mode (first, cost, fmultiplex1, tenth, zero, simple, threads) - Only check for available counters on x86_64 in test_module - Remove tests from Makefile.am TESTS that are run via rm_execution Generated with [Claude Code](https://claude.com/claude-code) Signed-off-by: Adrian Reber <areber@redhat.com>
76a649a to
f91fe16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.