Skip to content

Update pdsh tests and enable it in GitHub Actions#2337

Merged
adrianreber merged 2 commits intoopenhpc:4.xfrom
adrianreber:2026-01-14-pdsh
Jan 15, 2026
Merged

Update pdsh tests and enable it in GitHub Actions#2337
adrianreber merged 2 commits intoopenhpc:4.xfrom
adrianreber:2026-01-14-pdsh

Conversation

@adrianreber
Copy link
Copy Markdown
Member

@adrianreber adrianreber commented Jan 14, 2026

[TESTS:ALL]

@adrianreber
tests: modernize user-env/pdsh test
c7c395d 
Apply best practices from tests/BEST_PRACTICES.md:
- Add parallel execution flag to BATS shebang (-j 4)
- Use setup_file() for one-time initialization
- Fix relative paths in source/load statements (../common/)
- Use proper variable quoting with curly braces ("${VAR}")
- Add RESOURCE_MANAGER to test descriptions
- Skip SSH-based test in SIMPLE_CI environment
- Skip slurm-specific tests when not using slurm
- Use exec mode (-R exec) for pdsh in SIMPLE_CI
- Consistent tab indentation

Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Adrian Reber <areber@redhat.com>
@adrianreber
tests: add pdsh to spec_to_test_mapping.py
1738cb3 
Add pdsh and pdsh-mod-slurm to test mapping configuration so that
pdsh tests are properly triggered when the pdsh package is built.

Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Adrian Reber <areber@redhat.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 14, 2026

🚀 CCache Statistics

Configuration 🐧 RHEL 🦊 openEuler
🖥️ x86_64 / gnu15 🟡 33.29% 🟡 33.41%
🖥️ x86_64 / intel 🟡 34.86% -
💪 aarch64 / gnu15 🟡 29.33% 🟡 29.48%
📊 Detailed Statistics

openEuler (aarch64)

Cacheable calls:    1703 / 3036 (56.09%)
  Hits:              502 / 1703 (29.48%)
    Direct:          459 /  502 (91.43%)
    Preprocessed:     43 /  502 ( 8.57%)
  Misses:           1201 / 1703 (70.52%)
Uncacheable calls:  1333 / 3036 (43.91%)
Local storage:
  Cache size (GiB):  0.1 /  5.0 ( 1.57%)
  Hits:              502 / 1703 (29.48%)
  Misses:           1201 / 1703 (70.52%)

openEuler (x86_64)

Cacheable calls:    2110 / 3442 (61.30%)
  Hits:              705 / 2110 (33.41%)
    Direct:          662 /  705 (93.90%)
    Preprocessed:     43 /  705 ( 6.10%)
  Misses:           1405 / 2110 (66.59%)
Uncacheable calls:  1332 / 3442 (38.70%)
Local storage:
  Cache size (GiB):  0.1 /  5.0 ( 1.65%)
  Hits:              705 / 2110 (33.41%)
  Misses:           1405 / 2110 (66.59%)

RHEL (aarch64/gnu15)

Cacheable calls:    1705 / 3032 (56.23%)
  Hits:              500 / 1705 (29.33%)
    Direct:          455 /  500 (91.00%)
    Preprocessed:     45 /  500 ( 9.00%)
  Misses:           1205 / 1705 (70.67%)
Uncacheable calls:  1327 / 3032 (43.77%)
Local storage:
  Cache size (GiB):  0.1 /  5.0 ( 2.48%)
  Hits:              500 / 1705 (29.33%)
  Misses:           1205 / 1705 (70.67%)

RHEL (x86_64/gnu15)

Cacheable calls:    2112 / 3438 (61.43%)
  Hits:              703 / 2112 (33.29%)
    Direct:          658 /  703 (93.60%)
    Preprocessed:     45 /  703 ( 6.40%)
  Misses:           1409 / 2112 (66.71%)
Uncacheable calls:  1326 / 3438 (38.57%)
Local storage:
  Cache size (GiB):  0.1 /  5.0 ( 2.57%)
  Hits:              703 / 2112 (33.29%)
  Misses:           1409 / 2112 (66.71%)

RHEL (x86_64/intel)

Cacheable calls:    1635 / 4027 (40.60%)
  Hits:              570 / 1635 (34.86%)
    Direct:          565 /  570 (99.12%)
    Preprocessed:      5 /  570 ( 0.88%)
  Misses:           1065 / 1635 (65.14%)
Uncacheable calls:  2392 / 4027 (59.40%)
Local storage:
  Cache size (GiB):  0.1 /  5.0 ( 1.74%)
  Hits:              570 / 1635 (34.86%)
  Misses:           1065 / 1635 (65.14%)

🤖 Generated from workflow run 21005653858

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 14, 2026

Test Results

  309 files  +  273      1 errors  308 suites  +272   39m 34s ⏱️ + 38m 44s
  837 tests +  732    786 ✅ +  691  51 💤 +41  0 ❌ ±0 
1 691 runs  +1 514  1 595 ✅ +1 437  96 💤 +77  0 ❌ ±0 

For more details on these parsing errors, see this check.

Results for commit 1738cb3. ± Comparison against base commit 1034181.

This pull request removes 26 and adds 758 tests. Note that renamed tests count towards both. 
native_avail ‑ [perf-tools/papi] PAPI_L1_DCA available (intel)
native_avail ‑ [perf-tools/papi] PAPI_L1_DCM available (intel)
native_avail ‑ [perf-tools/papi] PAPI_TLB_DM available (intel)
rm_execution ‑ [perf-tools/papi] C Clock latency and resolution under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C L1 related events under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C branch accuracy under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C cycle ratio under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C dynamic memory info under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C simple smoke test under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C start, read, stop and again under resource manager (slurm/intel)
…

EasyBuild ‑ [EasyBuild] check for RPM
EasyBuild ‑ [EasyBuild] test executable
EasyBuild ‑ [EasyBuild] test install of tmux
computes ‑ [BOS] OS distribution matches  (0 active computes) 
computes ‑ [BOS] consistent kernel (0 active computes) 
computes ‑ [BOS] increased locked memory limits 
computes ‑ [BOS] syslog forwarding 
conman ‑ [ConMan] Verify conman binary available
conman ‑ [ConMan] Verify man page availability
conman ‑ [ConMan] Verify rpm version matches binary
…
This pull request removes 3 skipped tests and adds 44 skipped tests. Note that renamed tests count towards both. 
rm_execution ‑ [perf-tools/papi] C simple smoke test under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C start, read, stop and again under resource manager (slurm/intel)
rm_execution ‑ [perf-tools/papi] C threaded smoke test under resource manager (slurm/intel)

computes ‑ [BOS] OS distribution matches  (0 active computes) 
computes ‑ [BOS] increased locked memory limits 
ipmitool ‑ [OOB] ipmitool exists
ipmitool ‑ [OOB] ipmitool local bmc ping
ipmitool ‑ [OOB] ipmitool power status
ipmitool ‑ [OOB] ipmitool read CPU1 sensor data
ipmitool ‑ [OOB] ipmitool read sel log
ipmitool ‑ [OOB] istat exists
mem_limits ‑ [memlock] check increased hard limit
mem_limits ‑ [memlock] check increased soft limit
…

@adrianreber adrianreber merged commit 94773ca into openhpc:4.x Jan 15, 2026
35 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@adrianreber