Skip to content

tests: fix double-free in mfem ex1p_perf test#2345

Merged
adrianreber merged 1 commit intoopenhpc:4.xfrom
adrianreber:2026-01-18-double
Jan 18, 2026
Merged

tests: fix double-free in mfem ex1p_perf test#2345
adrianreber merged 1 commit intoopenhpc:4.xfrom
adrianreber:2026-01-18-double

Conversation

@adrianreber
Copy link
Copy Markdown
Member

The mesh pointer was deleted at line 279 after creating ParMesh, but the error path at line 341 tried to delete it again. Change to delete pmesh instead since that's the active mesh object.

Generated with Claude Code

The mesh pointer was deleted at line 279 after creating ParMesh,
but the error path at line 341 tried to delete it again. Change
to delete pmesh instead since that's the active mesh object.

Generated with [Claude Code](https://claude.ai/code)

Signed-off-by: Adrian Reber <areber@redhat.com>
@github-actions
Copy link
Copy Markdown

Test Results

27 files   -  6  27 suites   - 6   37s ⏱️ -2s
53 tests  - 24  49 ✅  - 24  4 💤 ±0  0 ❌ ±0 
99 runs   - 36  93 ✅  - 36  6 💤 ±0  0 ❌ ±0 

Results for commit d5d873c. ± Comparison against base commit a49da38.

This pull request removes 24 tests.
rm_execution ‑ [libs/Scotch] gout binary runs under resource manager (slurm/gnu15)
rm_execution ‑ [libs/Scotch] gout binary runs under resource manager (slurm/intel)
rm_execution ‑ [libs/Scotch] graph_map binary runs under resource manager (slurm/gnu15)
rm_execution ‑ [libs/Scotch] graph_map binary runs under resource manager (slurm/intel)
rm_execution ‑ [libs/Scotch] strat_seq binary runs under resource manager (slurm/gnu15)
rm_execution ‑ [libs/Scotch] strat_seq binary runs under resource manager (slurm/intel)
test_module ‑ [libs/Scotch] Verify SCOTCH module is loaded and matches rpm version (gnu15)
test_module ‑ [libs/Scotch] Verify SCOTCH module is loaded and matches rpm version (intel)
test_module ‑ [libs/Scotch] Verify SCOTCH_DIR is defined and directory exists (gnu15)
test_module ‑ [libs/Scotch] Verify SCOTCH_DIR is defined and directory exists (intel)
…

@github-actions
Copy link
Copy Markdown

🚀 CCache Statistics

Configuration 🐧 RHEL 🦊 openEuler
🖥️ x86_64 / gnu15 🔴 8.74% 🔴 8.64%
🖥️ x86_64 / intel 🔴 9.12% -
💪 aarch64 / gnu15 🔴 6.87% 🔴 6.92%
📊 Detailed Statistics

openEuler (aarch64)

Cacheable calls:    8853 / 11810 (74.96%)
  Hits:              613 /  8853 ( 6.92%)
    Direct:          592 /   613 (96.57%)
    Preprocessed:     21 /   613 ( 3.43%)
  Misses:           8240 /  8853 (93.08%)
Uncacheable calls:  2957 / 11810 (25.04%)
Local storage:
  Cache size (GiB):  0.3 /   5.0 ( 6.20%)
  Hits:              613 /  8853 ( 6.92%)
  Misses:           8240 /  8853 (93.08%)

openEuler (x86_64)

Cacheable calls:    9267 / 12233 (75.75%)
  Hits:              801 /  9267 ( 8.64%)
    Direct:          780 /   801 (97.38%)
    Preprocessed:     21 /   801 ( 2.62%)
  Misses:           8466 /  9267 (91.36%)
Uncacheable calls:  2966 / 12233 (24.25%)
Local storage:
  Cache size (GiB):  0.3 /   5.0 ( 6.38%)
  Hits:              801 /  9267 ( 8.64%)
  Misses:           8466 /  9267 (91.36%)

RHEL (aarch64/gnu15)

Cacheable calls:    8853 / 11803 (75.01%)
  Hits:              608 /  8853 ( 6.87%)
    Direct:          568 /   608 (93.42%)
    Preprocessed:     40 /   608 ( 6.58%)
  Misses:           8245 /  8853 (93.13%)
Uncacheable calls:  2950 / 11803 (24.99%)
Local storage:
  Cache size (GiB):  0.4 /   5.0 ( 7.14%)
  Hits:              608 /  8853 ( 6.87%)
  Misses:           8245 /  8853 (93.13%)

RHEL (x86_64/gnu15)

Cacheable calls:    9279 / 12248 (75.76%)
  Hits:              811 /  9279 ( 8.74%)
    Direct:          771 /   811 (95.07%)
    Preprocessed:     40 /   811 ( 4.93%)
  Misses:           8468 /  9279 (91.26%)
Uncacheable calls:  2969 / 12248 (24.24%)
Local storage:
  Cache size (GiB):  0.4 /   5.0 ( 7.36%)
  Hits:              811 /  9279 ( 8.74%)
  Misses:           8468 /  9279 (91.26%)

RHEL (x86_64/intel)

Cacheable calls:    9342 / 16440 (56.82%)
  Hits:              852 /  9342 ( 9.12%)
    Direct:          801 /   852 (94.01%)
    Preprocessed:     51 /   852 ( 5.99%)
  Misses:           8490 /  9342 (90.88%)
Uncacheable calls:  7098 / 16440 (43.18%)
Local storage:
  Cache size (GiB):  0.3 /   5.0 ( 6.76%)
  Hits:              852 /  9342 ( 9.12%)
  Misses:           8490 /  9342 (90.88%)

🤖 Generated from workflow run 21117710285

@adrianreber adrianreber merged commit 470333c into openhpc:4.x Jan 18, 2026
24 checks passed
@adrianreber adrianreber deleted the 2026-01-18-double branch January 18, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant