JDK-8296137: diags-examples.xml is broken

[jonathan-gibbons]

Please review some minor updates to the diags/examples mechanism, repairing some bitrot after one of the not-so-recent repo reorgs.

For bonus, I've added a target for the German version of the output.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296137: diags-examples.xml is broken

Reviewers

• Iris Clark (@irisclark - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10998/head:pull/10998
$ git checkout pull/10998

Update a local copy of the PR:
$ git checkout pull/10998
$ git pull https://git.openjdk.org/jdk pull/10998/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10998

View PR using the GUI difftool:
$ git pr show -t 10998

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10998.diff

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons The following labels will be automatically applied to this pull request:

• build
• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1550eb78)

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296137: diags-examples.xml is broken

Reviewed-by: iris, vromero, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 65 new commits pushed to the master branch:

• 8836b92: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
• 51f8e9b: 8296443: NMT: Remove cmdline_tracking_level handling code
• 087cedc: 8295261: RISC-V: Support ReductionV instructions for Vector API
• 556377a: 8296270: Memory leak in ClassLoader::setup_bootstrap_search_path_impl
• c2f7638: 8296335: Fix accessibility manual test instruction
• 91292d5: 8286301: Port JEP 425 to RISC-V
• 581133a: 8294696: BufferedInputStream.transferTo should drain buffer when mark set
• d8573b2: 8294488: Delete KCMS transforms wrappers
• f857f79: 8015739: Background of JInternalFrame is located out of JInternalFrame
• b847fb6: 8296414: [BACKOUT] JDK-8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
• ... and 55 more: https://git.openjdk.org/jdk/compare/d17bf51f91371072a758e775136af946192e771b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[vicente-romero-oracle]

lgtm

[magicus]

Looks good. Thanks for fixing, and sorry for breaking. :-( At some point, we should go through the files in make/langtools and check if they all are still needed, and so that we document how to test them, in case of future refactorings.

[jonathan-gibbons]

/integrate

[jonathan-gibbons]

Looks good. Thanks for fixing, and sorry for breaking. :-( At some point, we should go through the files in make/langtools and check if they all are still needed, and so that we document how to test them, in case of future refactorings.

Yeah, ideally we should execute code like this more of the time, perhaps figuring out how to run it in some sort of test.

[openjdk]

Going to push as commit f8b2574.
Since your change was applied there have been 67 commits pushed to the master branch:

• 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites
• d634dde: 8295354: Remove G1 incremental non-copy time calculation
• 8836b92: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
• 51f8e9b: 8296443: NMT: Remove cmdline_tracking_level handling code
• 087cedc: 8295261: RISC-V: Support ReductionV instructions for Vector API
• 556377a: 8296270: Memory leak in ClassLoader::setup_bootstrap_search_path_impl
• c2f7638: 8296335: Fix accessibility manual test instruction
• 91292d5: 8286301: Port JEP 425 to RISC-V
• 581133a: 8294696: BufferedInputStream.transferTo should drain buffer when mark set
• d8573b2: 8294488: Delete KCMS transforms wrappers
• ... and 57 more: https://git.openjdk.org/jdk/compare/d17bf51f91371072a758e775136af946192e771b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit f8b2574.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.