Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296445: C++ syntax error in jdwpTransport.h #11008

Closed
wants to merge 2 commits into from

Conversation

pandaapo
Copy link
Contributor

@pandaapo pandaapo commented Nov 6, 2022

Fix a syntax error in the code in jdwpTransport.h


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11008/head:pull/11008
$ git checkout pull/11008

Update a local copy of the PR:
$ git checkout pull/11008
$ git pull https://git.openjdk.org/jdk pull/11008/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11008

View PR using the GUI difftool:
$ git pr show -t 11008

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11008.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 6, 2022

👋 Welcome back pandaapo! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 6, 2022
@openjdk
Copy link

openjdk bot commented Nov 6, 2022

@pandaapo The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Nov 6, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 6, 2022

Webrevs

@DingliZhang
Copy link
Member

Hi @pandaapo thanks for your patch!
You need to change the name of this PR to 8296445: C++ syntax error in jdwpTransport.h to match the issue in JBS.

@pandaapo pandaapo changed the title JDK-8296445: Fix a syntax error. 8296445: C++ syntax error in jdwpTransport.h Nov 7, 2022
@pandaapo
Copy link
Contributor Author

pandaapo commented Nov 7, 2022

Hi @pandaapo thanks for your patch! You need to change the name of this PR to 8296445: C++ syntax error in jdwpTransport.h to match the issue in JBS.

Thanks. @DingliZhang

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good.

@openjdk
Copy link

openjdk bot commented Nov 7, 2022

@pandaapo This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296445: C++ syntax error in jdwpTransport.h

Reviewed-by: cjplummer, lmesnik, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 76790ad: 8295673: Deprecate and disable legacy parallel class loading workaround for non-parallel-capable class loaders
  • b6738c1: 8295663: Rephrase introduction to testing.md
  • 7e85b41: 8296154: [macos] Change "/Applications" to "Applications" in DMG image
  • 60db5f2: 8294020: improve errors for record declarations
  • 520db1e: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • b29817a: 8296479: Remove stray comment about POST_STRIP_CMD
  • b6ea69c: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • ... and 86 more: https://git.openjdk.org/jdk/compare/f3ca0cab75f2faf9ec88f7a380490c9589a27102...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@plummercj, @lmesnik, @sspitsyn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 7, 2022
@alexmenkov
Copy link

Need to update copyright year in the header

@pandaapo
Copy link
Contributor Author

pandaapo commented Nov 8, 2022

@lmesnik Thanks for your review. May I change Copyright (c) 2003, 2017, Oracle and/or its affiliates. to Copyright (c) 2003, 2022, Oracle and/or its affiliates. in the file header?

@lmesnik
Copy link
Member

lmesnik commented Nov 8, 2022

Sure, please update the copyright.

@pandaapo
Copy link
Contributor Author

pandaapo commented Nov 8, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@pandaapo
Your change (at version d71fe56) is now ready to be sponsored by a Committer.

@dholmes-ora
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit cf65605.
Since your change was applied there have been 99 commits pushed to the master branch:

  • 1169dc0: 8296447: RISC-V: Make the operands order of vrsub_vx/vrsub_vi consistent with RVV 1.0 spec
  • 4c80dff: 8296435: RISC-V: Small refactoring for increment/decrement
  • 47d2c7b: 8295376: Improve debug agent virtual thread performance when no debugger is attached
  • 76790ad: 8295673: Deprecate and disable legacy parallel class loading workaround for non-parallel-capable class loaders
  • b6738c1: 8295663: Rephrase introduction to testing.md
  • 7e85b41: 8296154: [macos] Change "/Applications" to "Applications" in DMG image
  • 60db5f2: 8294020: improve errors for record declarations
  • 520db1e: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • b29817a: 8296479: Remove stray comment about POST_STRIP_CMD
  • b6ea69c: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • ... and 89 more: https://git.openjdk.org/jdk/compare/f3ca0cab75f2faf9ec88f7a380490c9589a27102...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@dholmes-ora @pandaapo Pushed as commit cf65605.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
7 participants