JDK-8295934: IGV: keep node selection when changing view or graph

[tobiasholenstein]

In IGV nodes can be selected by clicking on it. When a user selects nodes in a certain view, e.g. "Cluster nodes into blocks" view, and then change to e.g. "Sea of nodes" view, the selection should be kept. Same when the user goes a different graph in the same group, the selection should be kept (as long as the nodes are still present)

New selection features:

• When opening a new graph and no nodes where selected previously the root nodes is centered.
• When a graph in the same group is opened, the previously selected nodes as selected as well if they are present in the graph. The selected nodes are centered in the new graph.
• The selected nodes are kept when changing the view, or the properties of the view (e.g. "show neighboring nodes semi-transparent")

• When "show neighboring nodes semi-transparent" is disabled, previously semi-transparent nodes that were selected are now unselected (because they are not visible anymore)
• It would also be desired adjust the scroll pane to center the selected nodes when changing view, graph, etc.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8295934: IGV: keep node selection when changing view or graph

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer) ⚠️ Review applies to c365e70a
• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/11062/head:pull/11062
$ git checkout pull/11062

Update a local copy of the PR:
$ git checkout pull/11062
$ git pull https://git.openjdk.org/jdk pull/11062/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11062

View PR using the GUI difftool:
$ git pr show -t 11062

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/11062.diff

[bridgekeeper]

👋 Welcome back tholenstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tobiasholenstein The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (8e8033da)
• 02: Full - Incremental (b74423b0)
• 01: Full - Incremental (f2521c3b)
• 00: Full (c365e70a)

[TobiHartmann]

Looks good to me functionality-wise.

[openjdk]

@tobiasholenstein This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295934: IGV: keep node selection when changing view or graph

Reviewed-by: thartmann, rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 66 new commits pushed to the master branch:

• 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
• 5551cb6: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
• 8a9eabb: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java
• 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
• 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
• 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
• c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• a7c2338: 8296900: CertificateValidity fields are not optional
• 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
• 749335d: 8291911: java/io/File/GetXSpace.java fails with "53687091200 != 161051996160"
• ... and 56 more: https://git.openjdk.org/jdk/compare/4a0093ccc4ec2880a789af3a50f30e44b686150e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[robcasloz]

Keeping the user's node selection across views and related graphs is a useful enhancement, thanks!

As a user, I only have an objection to selecting the Root node when opening a new graph without a previous selection: I would rather not select any node in that situation. Selecting the Root node forces the attention of the user to an arbitrary part of the graph, and this node is not relevant to all views, e.g. the CFG view of the current "Final Code" graph.

Regarding the code changes, I think it would be better for ease of reviewing and traceability to leave cleanups and unrelated refactorings (such as removal of unused imports in GraphViewerImplementation.java or not passing a SceneAnimator to LineWidget.java) to separate RFEs.

[tobiasholenstein]

Keeping the user's node selection across views and related graphs is a useful enhancement, thanks!

As a user, I only have an objection to selecting the Root node when opening a new graph without a previous selection: I would rather not select any node in that situation. Selecting the Root node forces the attention of the user to an arbitrary part of the graph, and this node is not relevant to all views, e.g. the CFG view of the current "Final Code" graph.

Regarding the code changes, I think it would be better for ease of reviewing and traceability to leave cleanups and unrelated refactorings (such as removal of unused imports in GraphViewerImplementation.java or not passing a SceneAnimator to LineWidget.java) to separate RFEs.

Hi @robcasloz
Thanks for your comment!
I agree that the root not should not be selected. I changed the PR accordingly: now the root node is only centered but not selected anymore.

I also agree that import of untouched files should not be touches. I reverted that.

The SceneAnimator in LineWidget.java was removed because in order to implement this PR I had to refactor the processOutputSlot() method which is the only place there LineWidget.java is initiated.

[robcasloz]

Looks good now, thanks for addressing my feedback and for the explanation about LineWidget.java.

[tobiasholenstein]

Thanks @TobiHartmann and @robcasloz for the reviews!

/integrate

[openjdk]

Going to push as commit 6f467cd.
Since your change was applied there have been 67 commits pushed to the master branch:

• 9adb728: 8295070: Introduce more target combinations for compiler flags
• 8ab70d3: 8294775: Shenandoah: reduce contention on _threads_in_evac
• 5551cb6: 8293166: jdk/jfr/jvm/TestDumpOnCrash.java fails on Linux ppc64le and Linux aarch64
• 8a9eabb: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java
• 873eccd: 8296923: JFR: jfr --version should return System.getProperty("java version")
• 93d6b1f: 8295711: Rename ZBarrierSetAssembler::load_at parameter name from "tmp_thread" to "tmp2"
• 2f7dc5c: 8296089: Remove debug agent code for special handling of Thread.resume()
• c71d87e: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• a7c2338: 8296900: CertificateValidity fields are not optional
• 3eb789a: 8296171: Compiler incorrectly rejects code with variadic method references
• ... and 57 more: https://git.openjdk.org/jdk/compare/4a0093ccc4ec2880a789af3a50f30e44b686150e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@tobiasholenstein Pushed as commit 6f467cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.