8312416: Tests in Locale should have more descriptive names#15032
8312416: Tests in Locale should have more descriptive names#15032justin-curtis-lu wants to merge 2 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
|
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 15 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit a9a3463.
Your commit was automatically rebased without conflicts. |
|
@justin-curtis-lu Pushed as commit a9a3463. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this change which renames tests for Locale from
bugNNNNNNN.javato something more descriptive.In addition to the name changes, accompanying copyright year, name usage within the test, and other minor changes were included. The test
bug4123285.javawas also removed, as it was never actually ran and java.applet.Applet is deprecated and marked for removal.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15032/head:pull/15032$ git checkout pull/15032Update a local copy of the PR:
$ git checkout pull/15032$ git pull https://git.openjdk.org/jdk.git pull/15032/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15032View PR using the GUI difftool:
$ git pr show -t 15032Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15032.diff
Webrev
Link to Webrev Comment