Skip to content

8312416: Tests in Locale should have more descriptive names#15032

Closed
justin-curtis-lu wants to merge 2 commits intoopenjdk:masterfrom
justin-curtis-lu:LocaleTestRenaming
Closed

8312416: Tests in Locale should have more descriptive names#15032
justin-curtis-lu wants to merge 2 commits intoopenjdk:masterfrom
justin-curtis-lu:LocaleTestRenaming

Conversation

@justin-curtis-lu
Copy link
Copy Markdown
Member

@justin-curtis-lu justin-curtis-lu commented Jul 26, 2023

Please review this change which renames tests for Locale from bugNNNNNNN.java to something more descriptive.

In addition to the name changes, accompanying copyright year, name usage within the test, and other minor changes were included. The test bug4123285.java was also removed, as it was never actually ran and java.applet.Applet is deprecated and marked for removal.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312416: Tests in Locale should have more descriptive names (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15032/head:pull/15032
$ git checkout pull/15032

Update a local copy of the PR:
$ git checkout pull/15032
$ git pull https://git.openjdk.org/jdk.git pull/15032/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15032

View PR using the GUI difftool:
$ git pr show -t 15032

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15032.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Jul 26, 2023

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 26, 2023

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jul 26, 2023
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Jul 26, 2023

Webrevs

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 26, 2023

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312416: Tests in Locale should have more descriptive names

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes
  • e9daf4a: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg
  • ... and 5 more: https://git.openjdk.org/jdk/compare/36f3bae556783e7a9ab27b2a2f8dbb0d38be3583...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2023
@justin-curtis-lu
Copy link
Copy Markdown
Member Author

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 28, 2023

Going to push as commit a9a3463.
Since your change was applied there have been 38 commits pushed to the master branch:

  • d9559f9: 8312612: handle WideCharToMultiByte return values
  • 34173ff: 8312574: jdk/jdk/jfr/jvm/TestChunkIntegrity.java fails with timeout
  • 47c4b99: 8312121: Fix -Wconversion warnings in tribool.hpp
  • a3d6723: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 4ae5a3e: 8306446: java/lang/management/ThreadMXBean/Locks.java transient failures
  • cad6114: 8304954: SegmentedCodeCache fails when using large pages
  • ba645da: 8313082: Enable CreateCoredumpOnCrash for testing in makefiles
  • c27c877: 8302017: Allocate BadPaddingException only if it will be thrown
  • c55d29f: 8312626: Resolve multiple definition of 'start_timer' when statically linking JDK native libraries with user code
  • 0ca2bfd: 8311104: dangling-gsl warning in libwixhelper.cpp
  • ... and 28 more: https://git.openjdk.org/jdk/compare/36f3bae556783e7a9ab27b2a2f8dbb0d38be3583...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 28, 2023
@openjdk openjdk bot closed this Jul 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 28, 2023
@openjdk
Copy link
Copy Markdown

openjdk bot commented Jul 28, 2023

@justin-curtis-lu Pushed as commit a9a3463.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants