Skip to content

8316295: Serial: Remove empty Generation::promotion_failure_occurred #15744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
albertnetymk wants to merge 1 commit into from
Closed

8316295: Serial: Remove empty Generation::promotion_failure_occurred #15744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/hotspot/share/gc/serial/defNewGeneration.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,8 +846,6 @@ void DefNewGeneration::collect(bool full,
from()->set_next_compaction_space(to());
heap->set_incremental_collection_failed();

// Inform the next generation that a promotion failure occurred.
_old_gen->promotion_failure_occurred();
_gc_tracer->report_promotion_failed(_promotion_failed_info);

// Reset the PromotionFailureALot counters.
Expand Down
6 changes: 0 additions & 6 deletions src/hotspot/share/gc/shared/generation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,12 +142,6 @@ class Generation: public CHeapObj<mtGC> {
// might be attempted in the worst case.
virtual bool promotion_attempt_is_safe(size_t max_promotion_in_bytes) const;

// For a non-young generation, this interface can be used to inform a
// generation that a promotion attempt into that generation failed.
// Typically used to enable diagnostic output for post-mortem analysis,
// but other uses of the interface are not ruled out.
virtual void promotion_failure_occurred() { /* does nothing */ }

// Return an estimate of the maximum allocation that could be performed
// in the generation without triggering any collection or expansion
// activity. It is "unsafe" because no locks are taken; the result
Expand Down