8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table

[MBaesken]

On Linux we had recently a crash looking like this

siginfo_t @ 0x00007fff2723dc98:
  Signal: 11 (SIGSEGV)
  Signal Code: 3 (unknown signal code)
  Address of faulting memory reference: 0x007fff8c31629838

Seems signal code 3 is
#define SEGV_BNDERR 3 /* failed address bound checks */

so we should add this to our signal code table; on AIX I cannot find this code so it might be Linux-only.
Even on Linux the define is not always available in the system headers so we better add a define .

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table (Bug - P4)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24255/head:pull/24255
$ git checkout pull/24255

Update a local copy of the PR:
$ git checkout pull/24255
$ git pull https://git.openjdk.org/jdk.git pull/24255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24255

View PR using the GUI difftool:
$ git pr show -t 24255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24255.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352946: SEGV_BND signal code of SIGSEGV missing from our signal-code table

Reviewed-by: mdoerr, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• 4ce9b4c: 8352435: Refactor CDS test library for execution and module packaging
• b73663a: 8351155: C1/C2: Remove 32-bit x86 specific FP rounding support
• 1bd0ce1: 8352918: Shenandoah: Verifier does not deactivate barriers as intended
• dc5c414: 8352762: Use EXACTFMT instead of expanded version where applicable
• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• 50ac24e: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception
• 79824c3: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK
• c50a0a1: 8352508: [Redo] G1: Pinned regions with pinned objects only reachable by native code crash VM
• ... and 26 more: https://git.openjdk.org/jdk/compare/84d3dc75e4ebd1a4724b09842fd5a63900536dd1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e2025e78)

[dholmes-ora]

FWIW there is also SEGV_PKUERR, but not sure we need to try and cater for every possibility here. Unless we are looking at the fields that will be set when these specific sub-signal occur, I'm not sure there is any real value in identifying them.

[MBaesken]

Yeah true, there is potentially more

/* `si_code' values for SIGSEGV signal.  */
enum
{
  SEGV_MAPERR = 1,              /* Address not mapped to object.  */
#  define SEGV_MAPERR   SEGV_MAPERR
  SEGV_ACCERR,                  /* Invalid permissions for mapped object.  */
#  define SEGV_ACCERR   SEGV_ACCERR
  SEGV_BNDERR,                  /* Bounds checking failure.  */
#  define SEGV_BNDERR   SEGV_BNDERR
  SEGV_PKUERR,                  /* Protection key checking failure.  */
#  define SEGV_PKUERR   SEGV_PKUERR
  SEGV_ACCADI,                  /* ADI not enabled for mapped object.  */
#  define SEGV_ACCADI   SEGV_ACCADI
  SEGV_ADIDERR,                 /* Disrupting MCD error.  */
#  define SEGV_ADIDERR  SEGV_ADIDERR
  SEGV_ADIPERR                  /* Precise MCD exception.  */
#  define SEGV_ADIPERR  SEGV_ADIPERR
};

but I only wanted to add the one we really saw recently in a crash.
I will check a few more old hserr , maybe I find more other sigcodes we do not cover currently.

[MBaesken]

I will check a few more old hserr , maybe I find more other sigcodes we do not cover currently.

I found a couple of Signal Code 3 cases in our old hserr, and also one strange Code 0 from macOS (not sure what that is)

siginfo_t @ 0x000070001548f6f8:
  Signal: 11 (SIGSEGV)
  Signal Code: 0 (unknown signal code)
  Address of faulting memory reference: 0x0000000000000000

[TheRealMDoerr]

LGTM.

[dholmes-ora]

Okay - seems harmless.

[MBaesken]

David and Martin, thanks for the reviews !

/integrate

[openjdk]

Going to push as commit bac2aa4.
Since your change was applied there have been 39 commits pushed to the master branch:

• cfc648b: 8352677: Opensource JMenu tests - series2
• 2ea1557: 8353005: AIX build broken after 8352481
• f4428e8: 8352920: Compilation failure: comparison of unsigned expression >= 0 is always true
• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• 4ce9b4c: 8352435: Refactor CDS test library for execution and module packaging
• b73663a: 8351155: C1/C2: Remove 32-bit x86 specific FP rounding support
• 1bd0ce1: 8352918: Shenandoah: Verifier does not deactivate barriers as intended
• dc5c414: 8352762: Use EXACTFMT instead of expanded version where applicable
• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• ... and 29 more: https://git.openjdk.org/jdk/compare/84d3dc75e4ebd1a4724b09842fd5a63900536dd1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit bac2aa4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.