8353005: AIX build broken after 8352481

[sendaoYan]

Hi all,

Apologize for the inconvenience, fix of JDK-8352481 make AIX build broekn.

According to the implementation of makefile function FLAGS_SETUP_LDFLAGS_HELPER which locate in make/autoconf/flags-ldflags.m4 file, only the combination of $TOOLCHAIN_TYPE == clang and $OPENJDK_TARGET_OS == linux support lld linker. So this PR limite the use of lld on linux instead of non-macos.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8353005: AIX build broken after 8352481 (Bug - P2)

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)
• Matthias Baesken (@MBaesken - Reviewer)
• Erik Joelsson (@erikj79 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/24270/head:pull/24270
$ git checkout pull/24270

Update a local copy of the PR:
$ git checkout pull/24270
$ git pull https://git.openjdk.org/jdk.git pull/24270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 24270

View PR using the GUI difftool:
$ git pr show -t 24270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/24270.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353005: AIX build broken after 8352481

Reviewed-by: mdoerr, mbaesken, erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

• 1bd0ce1: 8352918: Shenandoah: Verifier does not deactivate barriers as intended
• dc5c414: 8352762: Use EXACTFMT instead of expanded version where applicable
• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• 50ac24e: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception
• 79824c3: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK
• c50a0a1: 8352508: [Redo] G1: Pinned regions with pinned objects only reachable by native code crash VM
• 89e5c42: 8294954: Remove superfluous ResourceMarks when using LogStream
• 41f3eea: 8352624: Add missing {@code} to PassFailJFrame.Builder.splitUI
• e2cd70a: 8351151: Clean up x86 template interpreter after 32-bit x86 removal
• b990780: 8352393: AIX: Problem list serviceability/attach/AttachAPIv2/StreamingOutputTest.java
• ... and 9 more: https://git.openjdk.org/jdk/compare/24833403b6b93ca464720f00de0e8bd5e1c140be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bfb18d1f)

[MBaesken]

Hi, thanks for fixing the AIX build.
I wonder what to do with BSD , afaik they also use clang and probably have the flag that is missing on AIX ?

[TheRealMDoerr]

I think a positive list makes more sense. BSD can be added if needed.

[snake66]

I wonder what to do with BSD , afaik they also use clang and probably have the flag that is missing on AIX ?

I'll have a look at it, but lld is the default linker, at least on FreeBSD, so I don't think we need the flag to begin with.

[snake66]

Builds fine on FreeBSD.

[sendaoYan]

Thanks all for the reviews.

/integrate

[openjdk]

Going to push as commit 2ea1557.
Since your change was applied there have been 24 commits pushed to the master branch:

• f4428e8: 8352920: Compilation failure: comparison of unsigned expression >= 0 is always true
• d5b12c8: 8352890: Remove unnecessary Windows version check in FileFontStrike
• 58ef401: 5061061: SimpleDateFormat: unspecified behavior for reserved pattern letter
• 4ce9b4c: 8352435: Refactor CDS test library for execution and module packaging
• b73663a: 8351155: C1/C2: Remove 32-bit x86 specific FP rounding support
• 1bd0ce1: 8352918: Shenandoah: Verifier does not deactivate barriers as intended
• dc5c414: 8352762: Use EXACTFMT instead of expanded version where applicable
• 2eeda64: 8325132: CDS: Make sure the ArchiveRelocationMode is always printed in the log
• 50ac24e: 8351593: [JMH] test PhoneCode.Bulk reports NPE exception
• 79824c3: 8352184: Jtreg tests using CommandLineOptionTest.getVMTypeOption() and optionsvalidation.JVMOptionsUtils fail on static JDK
• ... and 14 more: https://git.openjdk.org/jdk/compare/24833403b6b93ca464720f00de0e8bd5e1c140be...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 2ea1557.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[TheRealMDoerr]

Thanks for fixing it!