Skip to content

Conversation

@parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Aug 25, 2025

Improve the sample queue size computation for the CPU-time sampler by increasing the size dynamically when needed, but keeping the default size small.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8366082: Improve queue size computation in CPU-time sampler (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26926/head:pull/26926
$ git checkout pull/26926

Update a local copy of the PR:
$ git checkout pull/26926
$ git pull https://git.openjdk.org/jdk.git pull/26926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 26926

View PR using the GUI difftool:
$ git pr show -t 26926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26926.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2025

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8366082: Improve queue size computation in CPU-time sampler

Reviewed-by: jbachorik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 217 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 25, 2025

@parttimenerd The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-jfr hotspot-jfr-dev@openjdk.org rfr Pull request is ready for review labels Aug 25, 2025
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2025

Comment on lines +78 to +86
List<LossEvent> ret = new ArrayList<>();
for (long start = 0; start < stopTimeMillis; start += widthMillis) {
long actualStart = Math.min(start, stopTimeMillis - widthMillis);
long lostSamples = events.stream()
.filter(e -> e.relativeTimeMillis >= actualStart && e.relativeTimeMillis < actualStart + widthMillis)
.mapToLong(e -> e.lostSamples)
.sum();
ret.add(new LossEvent(actualStart, lostSamples));
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: This could be probably more efficient by bulding time quantized bucket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. But I'm only getting 10 or so events, so I didn't think it would be worth it

Copy link

@jbachorik jbachorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few more minor questions/nits

@parttimenerd
Copy link
Contributor Author

I'm looking forward to your nits :)

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 9, 2025
@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 9, 2025

Going to push as commit 002f936.
Since your change was applied there have been 218 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 9, 2025
@openjdk openjdk bot closed this Sep 9, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 9, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 9, 2025
@openjdk
Copy link

openjdk bot commented Sep 9, 2025

@parttimenerd Pushed as commit 002f936.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

The new test is failing in our CI. I will file a bug and assign it to you.

@parttimenerd
Copy link
Contributor Author

/backport jdk25u-dev

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

@parttimenerd the backport was successfully created on the branch backport-parttimenerd-002f936e-master in my personal fork of openjdk/jdk25u-dev. To create a pull request with this backport targeting openjdk/jdk25u-dev:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 002f936e from the openjdk/jdk repository.

The commit being backported was authored by Johannes Bechberger on 9 Sep 2025 and was reviewed by Jaroslav Bachorik.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u-dev:

$ git fetch https://github.com/openjdk-bots/jdk25u-dev.git backport-parttimenerd-002f936e-master:backport-parttimenerd-002f936e-master
$ git checkout backport-parttimenerd-002f936e-master
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk25u-dev.git backport-parttimenerd-002f936e-master

⚠️ @parttimenerd You are not yet a collaborator in my fork openjdk-bots/jdk25u-dev. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants