-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8366082: Improve queue size computation in CPU-time sampler #26926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into |
|
@parttimenerd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 217 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@parttimenerd The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp
Outdated
Show resolved
Hide resolved
src/hotspot/share/jfr/periodic/sampling/jfrCPUTimeThreadSampler.cpp
Outdated
Show resolved
Hide resolved
| List<LossEvent> ret = new ArrayList<>(); | ||
| for (long start = 0; start < stopTimeMillis; start += widthMillis) { | ||
| long actualStart = Math.min(start, stopTimeMillis - widthMillis); | ||
| long lostSamples = events.stream() | ||
| .filter(e -> e.relativeTimeMillis >= actualStart && e.relativeTimeMillis < actualStart + widthMillis) | ||
| .mapToLong(e -> e.lostSamples) | ||
| .sum(); | ||
| ret.add(new LossEvent(actualStart, lostSamples)); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: This could be probably more efficient by bulding time quantized bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. But I'm only getting 10 or so events, so I didn't think it would be worth it
jbachorik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few more minor questions/nits
|
I'm looking forward to your nits :) |
|
/integrate |
|
Going to push as commit 002f936.
Your commit was automatically rebased without conflicts. |
|
@parttimenerd Pushed as commit 002f936. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
The new test is failing in our CI. I will file a bug and assign it to you. |
|
/backport jdk25u-dev |
|
@parttimenerd the backport was successfully created on the branch backport-parttimenerd-002f936e-master in my personal fork of openjdk/jdk25u-dev. To create a pull request with this backport targeting openjdk/jdk25u-dev:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk25u-dev: |
Improve the sample queue size computation for the CPU-time sampler by increasing the size dynamically when needed, but keeping the default size small.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26926/head:pull/26926$ git checkout pull/26926Update a local copy of the PR:
$ git checkout pull/26926$ git pull https://git.openjdk.org/jdk.git pull/26926/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26926View PR using the GUI difftool:
$ git pr show -t 26926Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26926.diff
Using Webrev
Link to Webrev Comment