Skip to content

Conversation

@parttimenerd
Copy link

@parttimenerd parttimenerd commented Dec 2, 2025

Hi all,

This pull request contains a backport of commit d27649fe from the openjdk/jdk repository.

The commit being backported was authored by Johannes Bechberger on 8 Oct 2025 and was reviewed by David Holmes and Andrei Pangin.

The backported is clean, although git had slight problems.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8367302 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/42/head:pull/42
$ git checkout pull/42

Update a local copy of the PR:
$ git checkout pull/42
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/42/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 42

View PR using the GUI difftool:
$ git pr show -t 42

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/42.diff

Using Webrev

Link to Webrev Comment

@parttimenerd parttimenerd marked this pull request as draft December 2, 2025 11:46
@parttimenerd parttimenerd marked this pull request as ready for review December 2, 2025 11:46
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 2, 2025

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 2, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d27649fe22a5bed9db72ac6c2595ac91f1fa28f8 8367302: New test jdk/jfr/event/profiling/TestCPUTimeSampleQueueAutoSizes.java from JDK-8366082 is failing Dec 2, 2025
@openjdk
Copy link

openjdk bot commented Dec 2, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Dec 2, 2025
@mlbridge
Copy link

mlbridge bot commented Dec 2, 2025

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 2, 2025

Hi @parttimenerd
the backport is not clean. It is only clean if Skara recognizes it as such. Please correct your PR message. Also describe the differences to the original change in the PR message.
Alternatively, correct the change so that Skara recognizes it as clean.
Thanks.

@parttimenerd
Copy link
Author

I'm confused by the backport. There must be changes that are not backported to JDK25.

@parttimenerd parttimenerd marked this pull request as draft December 2, 2025 16:11
@openjdk openjdk bot removed the rfr Pull request is ready for review label Dec 2, 2025
@parttimenerd
Copy link
Author

I probably found the culprit: openjdk/jdk#26926 has never been backported

@parttimenerd
Copy link
Author

The new backport in question is #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base

Development

Successfully merging this pull request may close these issues.

2 participants