8368180: RISC-V: Remove redundant ext_Zicboz.enable_feature()

[DingliZhang]

Hi,
Can you help to review this patch? Thanks!

We can clean up the duplicate call to ext_Zicboz.enable_feature() in VM_Version::rivos_features(), as it is already invoked at

jdk/src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp

Line 286 in cc65836

ext_Zicboz.enable_feature();

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8368180: RISC-V: Remove redundant ext_Zicboz.enable_feature() (Enhancement - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Gui Cao (@zifeihan - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27409/head:pull/27409
$ git checkout pull/27409

Update a local copy of the PR:
$ git checkout pull/27409
$ git pull https://git.openjdk.org/jdk.git pull/27409/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27409

View PR using the GUI difftool:
$ git pr show -t 27409

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27409.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dzhang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@DingliZhang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368180: RISC-V: Remove redundant ext_Zicboz.enable_feature()

Reviewed-by: fyang, gcao

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@DingliZhang The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9f458b75)
• 00: Full (b523e45e)

[RealFYang]

LGTM. Thanks.

[Hamlin-Li]

Hey, Thanks for the cleanup.
Can you drop this pr? we'll cleanup it up finally together after we verify the extensions.

[DingliZhang]

Hey, Thanks for the cleanup. Can you drop this pr? we'll cleanup it up finally together after we verify the extensions.

@Hamlin-Li Sure! Do I need to assign the issue to you?

[Hamlin-Li]

@DingliZhang It's fine, you can just close it. I'll go through all the extensions altogether when I work on it. Thanks!

[DingliZhang]

This problem still exists, and we'd better go on.
/open

[openjdk]

@DingliZhang Unknown command reopen - for a list of valid commands use /help.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot-runtime. This can be overridden with the /reviewers command.

[DingliZhang]

/template append

[openjdk]

@DingliZhang The pull request template has been appended to the pull request body

[zifeihan]

LGTM, thanks.

[DingliZhang]

Thanks all for the review!
/integrate

[openjdk]

Going to push as commit 31dede3.
Since your change was applied there have been 7 commits pushed to the master branch:

• 333deb2: 8380967: Canceled HttpClient.sendAsync futures throw inconsistent exceptions
• 05c93a1: 8387411: C2: assert((in_vt->isa_pvectmask() == nullptr) == (vt->isa_pvectmask() == nullptr)) failed: Both BVectMask, or both NVectMask, or both PVectMask
• 182b0cb: 8387937: C1: aarch64: two-arg add_debug_info_for_branch looks obsolete
• ... and 4 more: https://git.openjdk.org/jdk/compare/2dc0c1c5a90610460a68803655be351c85bec9e3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@DingliZhang Pushed as commit 31dede3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.