Skip to content

8372120: Add missing sound keyword to MIDI tests #28382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
azuev-java wants to merge 1 commit into from
Closed

8372120: Add missing sound keyword to MIDI tests #28382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/jdk/javax/sound/midi/MidiDeviceConnectors/TestAllDevices.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
/**
* @test
* @bug 4933700
* @key sound
* @summary Tests that default devices return MidiDeviceTransmitter/Receiver and returned objects return correct MidiDevice
* @compile TestAllDevices.java
* @run main TestAllDevices
Expand Down
1 change: 1 addition & 0 deletions test/jdk/javax/sound/midi/SysexMessage/SendRawSysexMessage.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
/**
* @test
* @bug 8074211 8237495 8301310
* @key sound
* @summary fail with memory errors when asked to send a sysex message starting
* with 0xF7
*/
Expand Down
1 change: 1 addition & 0 deletions test/jdk/javax/sound/midi/spi/MidiDeviceProvider/ExpectedNPEOnNull.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
/**
* @test
* @bug 8143909
* @key sound
* @author Sergey Bylokhov
Copy link
Member

@mrserb mrserb Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exception causes this(and others) tests to fail if the hardware device is not configured? please add it to the PR of jbs.

Copy link
Member Author

@azuev-java azuev-java Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can cause these tests to hang in native methods if device is not configured or not accessible in latest macOS. We need finer control as to which tests needs not to be executed on such machines.

Copy link
Member

@mrserb mrserb Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it seems like a product bug that this test hangs. Why don’t you list add it to the problem list?

What are the stack traces?

*/
public final class ExpectedNPEOnNull {
Expand Down
1 change: 1 addition & 0 deletions test/jdk/javax/sound/midi/spi/MidiDeviceProvider/FakeInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
/**
* @test
* @bug 8059743
* @key sound
* @summary MidiDeviceProvider shouldn't returns incorrect results in case of
* some unknown MidiDevice.Info
* @author Sergey Bylokhov
Expand Down
1 change: 1 addition & 0 deletions test/jdk/javax/sound/midi/spi/MidiDeviceProvider/UnsupportedInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
/**
* @test
* @bug 8058115
* @key sound
* @summary MidiDeviceProvider shouldn't returns incorrect results in case of
* unsupported MidiDevice.Info
* @author Sergey Bylokhov
Expand Down