8372120: Add missing sound keyword to MIDI tests

[azuev-java]

Add missing keyword to the tests where it is required but missing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8372120: Add missing sound keyword to MIDI tests (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Author)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28382/head:pull/28382
$ git checkout pull/28382

Update a local copy of the PR:
$ git checkout pull/28382
$ git pull https://git.openjdk.org/jdk.git pull/28382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28382

View PR using the GUI difftool:
$ git pr show -t 28382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28382.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8372120: Add missing sound keyword to MIDI tests

Reviewed-by: kcr, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 152cd4d: 8371956: Convert OopStorage to use Atomic
• aeea849: 8371164: ArrayList.addAll() optimizations
• 256a9be: 8280469: C2: CHA support for interface calls when inlining through method handle linker
• ... and 3 more: https://git.openjdk.org/jdk/compare/4a975637a144fa8aa449a1419e656721833513b5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@azuev-java The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a2d37d97)

[lawrence-andrew]

LGTM

[kevinrushforth]

LGTM

[mrserb]

What exception causes this(and others) tests to fail if the hardware device is not configured? please add it to the PR of jbs.

[azuev-java]

It can cause these tests to hang in native methods if device is not configured or not accessible in latest macOS. We need finer control as to which tests needs not to be executed on such machines.

[mrserb]

Then it seems like a product bug that this test hangs. Why don’t you list add it to the problem list?

What are the stack traces?

[dholmes-ora]

Seems fine to me. Just to be clear these "key" values simply allow you to tell jtreg to include/exclude a test based on the key value, so it just gives finer-grained control.

[azuev-java]

Seems fine to me. Just to be clear these "key" values simply allow you to tell jtreg to include/exclude a test based on the key value, so it just gives finer-grained control.

Yes, the key will not alter the logic of the test itself - just add a means to be included or excluded depending on the test harness parameters.

[azuev-java]

/integrate

[openjdk]

Going to push as commit 902aa4d.
Since your change was applied there have been 6 commits pushed to the master branch:

• 152cd4d: 8371956: Convert OopStorage to use Atomic
• aeea849: 8371164: ArrayList.addAll() optimizations
• 256a9be: 8280469: C2: CHA support for interface calls when inlining through method handle linker
• ... and 3 more: https://git.openjdk.org/jdk/compare/4a975637a144fa8aa449a1419e656721833513b5...master

Your commit was automatically rebased without conflicts.

[openjdk]

@azuev-java Pushed as commit 902aa4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.