8334549: [Sound] Test timed out: javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java

[prrace]

This sound test appears to need the sound key which is needed so that it can be filtered (in or out) depending on whether sound resources / devices are available in a test environment.

This sound test passes (as tested many times) when run in such an environment, so I here add the key.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334549: [Sound] Test timed out: javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java (Bug - P4)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28752/head:pull/28752
$ git checkout pull/28752

Update a local copy of the PR:
$ git checkout pull/28752
$ git pull https://git.openjdk.org/jdk.git pull/28752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28752

View PR using the GUI difftool:
$ git pr show -t 28752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28752.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334549: [Sound] Test timed out: javax/sound/sampled/Clip/OpenNonIntegralNumberOfSampleframes.java

Reviewed-by: aivanov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• 413f852: 8369736: Add management interface for AOT cache creation
• 11aa6e1: 8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (c1046879)

[mrserb]

What is the exception that caused it to fail when no hardware is present on the system? This test was expected to verify that invalid parameters were passed to the method and that it should throw an IllegalArgumentException. Therefore, it should work both with and without audio devices.

[mrserb]

Is it fails on the same environment mentioned here #28382? As said in that PR, if it really hangs that looks like a product bug.

[aivanov-jdk]

Looks good to me.

Shall we bump the copyright year?

[prrace]

/integrate

[openjdk]

Going to push as commit 52aa7fe.
Since your change was applied there have been 2 commits pushed to the master branch:

• 413f852: 8369736: Add management interface for AOT cache creation
• 11aa6e1: 8373270: GCC 14.2.0 reports warning: '%s' directive output may be truncated

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit 52aa7fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[mrserb]

Is the hang considered not a product bug, or is the bug simply being ignored?