8375573: JTable ignores setPreferredWidth during initial layout when AUTO_RESIZE_LAST_COLUMN is enabled by prsadhuk · Pull Request #29291 · openjdk/jdk

prsadhuk · 2026-01-19T02:18:06Z

AUTO_RESIZE_LAST_COLUMN handling was done in JDK-8234071 but it didn't honour the preferred width if it is already been set for each column so when layouting is done, it only sees the resizingColumn
is set to AUTO_RESIZE_LAST_COLUMN and adjust only the last column and distribute width equally to all other column.

Fix is made to honour the user-set preferred column width even if auto-resize mode is set to LAST_COLUMN

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8375573: JTable ignores setPreferredWidth during initial layout when AUTO_RESIZE_LAST_COLUMN is enabled (Bug - P3)

Reviewers

Tejesh R (@TejeshR13 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/29291/head:pull/29291
$ git checkout pull/29291

Update a local copy of the PR:
$ git checkout pull/29291
$ git pull https://git.openjdk.org/jdk.git pull/29291/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 29291

View PR using the GUI difftool:
$ git pr show -t 29291

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/29291.diff

Using Webrev

Link to Webrev Comment

…AUTO_RESIZE_LAST_COLUMN is enabled

bridgekeeper · 2026-01-19T02:19:31Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2026-01-19T02:20:32Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8375573: JTable ignores setPreferredWidth during initial layout when AUTO_RESIZE_LAST_COLUMN is enabled

Reviewed-by: tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 148 new commits pushed to the master branch:

0f087a7: 8376051: gc/stress/TestStressG1Uncommit.java fails assertLessThan: expected that xxx < xxx
25d2b52: 8328046: Need to keep leading zeros in TlsPremasterSecret of TLS1.3 DHKeyAgreement
d6ebcf8: 8357471: GenShen: Share collector reserves between young and old
... and 145 more: https://git.openjdk.org/jdk/compare/c000343bbb1d822d2cee37e1a27672cfb3128bee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2026-01-19T02:21:44Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2026-01-19T05:17:54Z

Webrevs

01: Full - Incremental (622fc1fb)
00: Full (521aa029)

TejeshR13 · 2026-01-21T05:16:35Z

+        // is set to last column on account of
+        // AUTO_RESIZE_LAST_COLUMN autoResizeMode
+        for (int i = 0; i < columnModel.getColumnCount(); i++) {
+            if (columnModel.getColumn(i).getPreferredWidth() != 75


Why are we using hardcoded value here ? Any particular reason for checking width against value 75 ?

Because default width is such and there is no way to ascertain default width..

jdk/src/java.desktop/share/classes/javax/swing/table/TableColumn.java

Lines 523 to 524 in b5727d2

* Returns the width of the <code>TableColumn</code>. The default width is

* 75.

jdk/src/java.desktop/share/classes/javax/swing/table/TableColumn.java

Lines 556 to 557 in b5727d2

* Returns the preferred width of the <code>TableColumn</code>.

* The default preferred width is 75.

Got it, it's been set here -

jdk/src/java.desktop/share/classes/javax/swing/table/TableColumn.java

Line 211 in b5727d2

this(modelIndex, 75, null, null);

@TejeshR13 any other comments?

TejeshR13 · 2026-01-22T10:24:10Z

+        for (int i = 0; i < columnModel.getColumnCount(); i++) {
+            if (columnModel.getColumn(i).getPreferredWidth() != 75
+                    && columnModel.getColumn(i).getWidth() == 75) {
+                prefWidthSet = true;


Can break the loop for first true condition instead of iterating through all the columns ?

Yes, can do..Updated..

TejeshR13 · 2026-01-22T10:24:54Z

+                                  " initial layout when AUTO_RESIZE_LAST_COLUMN is enabled");
+                }
+            } finally {
+                if (frame != null) {


Normally we do this inside EDT.

its already under EDT

Ok, I see this is in EDT. But now this one will throw InvocationTargetException along with RuntimeException ? I guess it's better to move out the exception handling outside EDT.

Dont think it matters..There are many tests that follows this..throwing exception inside EDT..
additionally it will result in volatile usage of columnCount/width which we can avoid here..

prsadhuk · 2026-01-30T08:30:13Z

/integrate

openjdk · 2026-01-30T08:31:31Z

Going to push as commit 55375e9.
Since your change was applied there have been 252 commits pushed to the master branch:

9fef14a: 8375571: Compiler crash when using record pattern matching with a generic type parameter shadowing a record class
2953e0f: 8371162: Compiler warns about implicit cast from long to int in shift operation
9a10cce: 8374506: Incorrect positioning of arrow icon in parent JMenu in Windows L&F
... and 249 more: https://git.openjdk.org/jdk/compare/c000343bbb1d822d2cee37e1a27672cfb3128bee...master

Your commit was automatically rebased without conflicts.

openjdk · 2026-01-30T08:31:43Z

@prsadhuk Pushed as commit 55375e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

prsadhuk added 2 commits January 19, 2026 02:07

8375573: JTable ignores setPreferredWidth during initial layout when …

9a42fdb

…AUTO_RESIZE_LAST_COLUMN is enabled

8375573: JTable ignores setPreferredWidth during initial layout when …

9b6ac60

…AUTO_RESIZE_LAST_COLUMN is enabled

openjdk Bot changed the title ~~8375573: JTable ignores setPreferredWidth during initial layout when AUTO_RESIZE_LAST_COLUMN is enabled~~ 8375573: JTable ignores setPreferredWidth during initial layout when AUTO_RESIZE_LAST_COLUMN is enabled Jan 19, 2026

openjdk Bot added the client client-libs-dev@openjdk.org label Jan 19, 2026

jcheck

521aa02

openjdk Bot added the rfr Pull request is ready for review label Jan 19, 2026

TejeshR13 reviewed Jan 21, 2026

View reviewed changes

TejeshR13 reviewed Jan 22, 2026

View reviewed changes

Bail out early if prefSize is set for a column

622fc1f

TejeshR13 approved these changes Jan 23, 2026

View reviewed changes

openjdk Bot added the ready Pull request is ready to be integrated label Jan 23, 2026

openjdk Bot added the integrated Pull request has been integrated label Jan 30, 2026

openjdk Bot closed this Jan 30, 2026

openjdk Bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2026

prsadhuk deleted the JDK-8375573 branch January 30, 2026 08:31

prsadhuk mentioned this pull request Aug 6, 2026

8387267: Editor for the last column in JTable is hard to activate after AUTO_RESIZE_LAST_COLUMN was configured #31704

Open

4 tasks

	* Returns the width of the <code>TableColumn</code>. The default width is
	* 75.

	* Returns the preferred width of the <code>TableColumn</code>.
	* The default preferred width is 75.

Uh oh!

Conversation

prsadhuk commented Jan 19, 2026 • edited by openjdk Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper Bot commented Jan 19, 2026

Uh oh!

openjdk Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge Bot commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prsadhuk Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

prsadhuk commented Jan 30, 2026

Uh oh!

openjdk Bot commented Jan 30, 2026

Uh oh!

openjdk Bot commented Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

prsadhuk commented Jan 19, 2026 •

edited by openjdk Bot

Loading

openjdk Bot commented Jan 19, 2026 •

edited

Loading

openjdk Bot commented Jan 19, 2026 •

edited

Loading

mlbridge Bot commented Jan 19, 2026 •

edited

Loading

prsadhuk Jan 22, 2026 •

edited

Loading