8382878: RISC-V: Missing InlineSkippedInstructionsCounter in ZGC barriers stubs

[zifeihan]

Hi, Please review this small change.
I happened to find some InlineSkippedInstructionsCounters are missing in ZGC barriers stubs.
This may affect performance in certain cases [1]. So this adds them back just like other CPU platforms.
Testing: hs:tier1 - hs:tier3 using fastdebug build on linux-riscv64 platforms.

[1] https://bugs.openjdk.org/browse/JDK-8333226

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8382878: RISC-V: Missing InlineSkippedInstructionsCounter in ZGC barriers stubs (Bug - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Dingli Zhang (@DingliZhang - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/30893/head:pull/30893
$ git checkout pull/30893

Update a local copy of the PR:
$ git checkout pull/30893
$ git pull https://git.openjdk.org/jdk.git pull/30893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 30893

View PR using the GUI difftool:
$ git pr show -t 30893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/30893.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8382878: RISC-V: Missing InlineSkippedInstructionsCounter in ZGC barriers stubs

Reviewed-by: fyang, dzhang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

• 9ce60ba: 8381723: Crash in fastdebug VM: assert(strlen(name1) + strlen(name2) < sizeof(stub_id)) failed
• 7fcf2bb: 8180483: sun.net.www.protocol.http.HttpClient::available may consume one character
• 9813fd4: 8382934: LateInlineQueueDrainTest.java fails without diagnostic option
• ... and 25 more: https://git.openjdk.org/jdk/compare/7e1ed28cd5ae9ca652a4cc350dd6723c267658c9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang, @DingliZhang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@zifeihan The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[openjdk]

The total number of required reviews for this PR has been set to 2 based on the presence of this label: hotspot. This can be overridden with the /reviewers command.

[mlbridge]

Webrevs

• 00: Full (d1b60e23)

[RealFYang]

Looks fine. Thanks for finding this.

[DingliZhang]

LGTM, thanks!

[zifeihan]

Thanks all for the review.
/integrate

[openjdk]

@zifeihan
Your change (at version d1b60e2) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 19ffa60.
Since your change was applied there have been 28 commits pushed to the master branch:

• 9ce60ba: 8381723: Crash in fastdebug VM: assert(strlen(name1) + strlen(name2) < sizeof(stub_id)) failed
• 7fcf2bb: 8180483: sun.net.www.protocol.http.HttpClient::available may consume one character
• 9813fd4: 8382934: LateInlineQueueDrainTest.java fails without diagnostic option
• ... and 25 more: https://git.openjdk.org/jdk/compare/7e1ed28cd5ae9ca652a4cc350dd6723c267658c9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zifeihan Pushed as commit 19ffa60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.