Vector API can be value classes! - #32113
Conversation
|
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
wenshao
left a comment
There was a problem hiding this comment.
— qwen3.8-max-preview via Qwen Code /review
ExE-Boss
left a comment
There was a problem hiding this comment.
Note that the lworld+vector branch also has changes to VectorSupport to include a multi‑field‑based approach1, thus avoiding identity issues caused by the use of arrays.
Footnotes
-
Which act like fixed‑size frozen value arrays (as in frozen arrays that are values) ↩
| public VectorPayload(Object payload) { | ||
| this.payload = payload; | ||
| } |
There was a problem hiding this comment.
This probably should do the this.payload assignment before the super() call, even when preview features are disabled:
| public VectorPayload(Object payload) { | |
| this.payload = payload; | |
| super(); | |
| } |
Testing: Build JDK, run jshell with
--add-modules jdk.incubator.vector --enable-preview, and run this:Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32113/head:pull/32113$ git checkout pull/32113Update a local copy of the PR:
$ git checkout pull/32113$ git pull https://git.openjdk.org/jdk.git pull/32113/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 32113View PR using the GUI difftool:
$ git pr show -t 32113Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32113.diff