Skip to content

Vector API can be value classes! - #32113

Draft
liach wants to merge 1 commit into
openjdk:masterfrom
liachmodded:exp/vector-value-decl
Draft

Vector API can be value classes!#32113
liach wants to merge 1 commit into
openjdk:masterfrom
liachmodded:exp/vector-value-decl

Conversation

@liach

@liach liach commented Jul 31, 2026

Copy link
Copy Markdown
Member

Testing: Build JDK, run jshell with --add-modules jdk.incubator.vector --enable-preview, and run this:

import module jdk.incubator.vector;
IntVector.class.isValue()


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/32113/head:pull/32113
$ git checkout pull/32113

Update a local copy of the PR:
$ git checkout pull/32113
$ git pull https://git.openjdk.org/jdk.git pull/32113/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32113

View PR using the GUI difftool:
$ git pr show -t 32113

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/32113.diff

@bridgekeeper

bridgekeeper Bot commented Jul 31, 2026

Copy link
Copy Markdown

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Jul 31, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot added build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 31, 2026
@openjdk

openjdk Bot commented Jul 31, 2026

Copy link
Copy Markdown

@liach The following labels will be automatically applied to this pull request:

  • build
  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@wenshao wenshao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Downgraded from Approve to Comment: CI failing: Pre-submit tests - windows-aarch64 / test - Test (tier1), Pre-submit tests - linux-cross-compile / build - Build / test, jcheck-openjdk/jdk-32113. Reviewed.

— qwen3.8-max-preview via Qwen Code /review

@ExE-Boss ExE-Boss left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the lworld+vector branch also has changes to VectorSupport to include a multi‑field‑based approach1, thus avoiding identity issues caused by the use of arrays.

Footnotes

  1. Which act like fixed‑size frozen value arrays (as in frozen arrays that are values)

Comment on lines 169 to 171
public VectorPayload(Object payload) {
this.payload = payload;
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably should do the this.payload assignment before the super() call, even when preview features are disabled:

Suggested change
public VectorPayload(Object payload) {
this.payload = payload;
super();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org core-libs core-libs-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants