Skip to content

Conversation

@dfuch
Copy link
Member

@dfuch dfuch commented Jun 10, 2021

Another change brought by jtreg 6+1 in the behavior of @BeforeMethod.
Now throwing an exception in @BeforeMethod causes all annotated methods to be skipped, not just those annotated with @Test.

HttpClient tests that use @BeforeMethod and ITestContext need to be updated to work around the new behavior.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268555: Update HttpClient tests that use ITestContext to jtreg 6+1

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4465/head:pull/4465
$ git checkout pull/4465

Update a local copy of the PR:
$ git checkout pull/4465
$ git pull https://git.openjdk.java.net/jdk pull/4465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4465

View PR using the GUI difftool:
$ git pr show -t 4465

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4465.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 10, 2021

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 10, 2021
@openjdk
Copy link

openjdk bot commented Jun 10, 2021

@dfuch The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 10, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 10, 2021

Webrevs

@dfuch
Copy link
Member Author

dfuch commented Jun 10, 2021

Closing this PR in favor of one targeted at JDK 17: openjdk/jdk17#5

@dfuch dfuch closed this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

net net-dev@openjdk.org rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant