Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268727: Remove unused slowpath locking method in OptoRuntime #4490

Closed
wants to merge 1 commit into from

Conversation

miao-zheng
Copy link
Contributor

@miao-zheng miao-zheng commented Jun 15, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268727: Remove unused slowpath locking method in OptoRuntime

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4490/head:pull/4490
$ git checkout pull/4490

Update a local copy of the PR:
$ git checkout pull/4490
$ git pull https://git.openjdk.java.net/jdk pull/4490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4490

View PR using the GUI difftool:
$ git pr show -t 4490

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4490.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 15, 2021

👋 Welcome back miao-zheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@miao-zheng The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot rfr labels Jun 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 15, 2021

Webrevs

@miao-zheng
Copy link
Contributor Author

@miao-zheng miao-zheng commented Jun 15, 2021

/test

@openjdk
Copy link

@openjdk openjdk bot commented Jun 15, 2021

@miao-zheng you need to get approval to run the tests in tier1 for commits up until 94db2f5

@openjdk openjdk bot added the test-request label Jun 15, 2021
@miao-zheng
Copy link
Contributor Author

@miao-zheng miao-zheng commented Jun 21, 2021

Could someone help to review this change? Thanks.

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 21, 2021

/label add hotspot-compiler
/label remove hotspot-dev

@openjdk openjdk bot added the hotspot-compiler label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@dholmes-ora
The hotspot-compiler label was successfully added.

@openjdk openjdk bot removed the hotspot label Jun 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 21, 2021

@dholmes-ora
The hotspot label was successfully removed.

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jun 21, 2021

Redirecting to the compiler team.

@@ -310,7 +310,7 @@ public void makeMethodNotCompilable(Executable method, int compLevel,
makeMethodNotCompilable0(method, compLevel, isOsr);
}
public int getMethodCompilationLevel(Executable method) {
return getMethodCompilationLevel(method, false /*not ost*/);
return getMethodCompilationLevel(method, false /*not osr*/);
Copy link
Contributor

@zhengyu123 zhengyu123 Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated, should be fixed in a separate CR?

Copy link
Contributor Author

@miao-zheng miao-zheng Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small typo fix, can I merge it in this patch?

Copy link
Contributor

@zhengyu123 zhengyu123 Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the convention is "no"

Copy link
Contributor Author

@miao-zheng miao-zheng Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks for your review. I have removed this change.

@dean-long
Copy link
Member

@dean-long dean-long commented Jun 22, 2021

/test

@openjdk openjdk bot removed the test-request label Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

Could not create test job

Copy link
Member

@dean-long dean-long left a comment

Looks good, and trivial. It's strange that some pre-commit tests failed on Windows.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

⚠️ @miao-zheng the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8268727
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@miao-zheng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268727: Remove unused slowpath locking method in OptoRuntime

Reviewed-by: dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

  • cd678a3: 8268368: Adopt cast notation for JavaThread conversions
  • b6cfca8: Merge
  • 35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
  • dc12cb7: 8267652: c2 loop unrolling by 8 results in reading memory past array
  • 578c55b: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
  • 8fa2520: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken
  • 9ec7180: 8268524: nmethod::post_compiled_method_load_event racingly called on zombie
  • 01f12fb: 8266631: StandardJavaFileManager: getJavaFileObjects() impl violates the spec
  • 6b14c8a: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling
  • ef4ba22: 8268349: Provide clear run-time warnings about Security Manager deprecation
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/9f3c7e74ff00a7550742ed8b9d6671c2d4bb6041...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@zhengyu123, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jun 23, 2021
@miao-zheng
Copy link
Contributor Author

@miao-zheng miao-zheng commented Jun 23, 2021

The same test cases fail in other Pull requests on windows, for example: #4534.
I think these test cases fail are random.

@dean-long
Copy link
Member

@dean-long dean-long commented Jun 23, 2021

I agree, test failures seem unrelated to this change.

@miao-zheng
Copy link
Contributor Author

@miao-zheng miao-zheng commented Jun 23, 2021

@dean-long @zhengyu123 Thanks for your review.

@miao-zheng
Copy link
Contributor Author

@miao-zheng miao-zheng commented Jun 23, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@miao-zheng
Your change (at version 07b3280) is now ready to be sponsored by a Committer.

@huishi-hs
Copy link

@huishi-hs huishi-hs commented Jun 23, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit ae3eedc.
Since your change was applied there have been 117 commits pushed to the master branch:

  • cd678a3: 8268368: Adopt cast notation for JavaThread conversions
  • b6cfca8: Merge
  • 35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
  • dc12cb7: 8267652: c2 loop unrolling by 8 results in reading memory past array
  • 578c55b: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
  • 8fa2520: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken
  • 9ec7180: 8268524: nmethod::post_compiled_method_load_event racingly called on zombie
  • 01f12fb: 8266631: StandardJavaFileManager: getJavaFileObjects() impl violates the spec
  • 6b14c8a: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling
  • ef4ba22: 8268349: Provide clear run-time warnings about Security Manager deprecation
  • ... and 107 more: https://git.openjdk.java.net/jdk/compare/9f3c7e74ff00a7550742ed8b9d6671c2d4bb6041...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@huishi-hs @miao-zheng Pushed as commit ae3eedc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler integrated
5 participants