8268727: Remove unused slowpath locking method in OptoRuntime #4490

miao-zheng · 2021-06-15T03:18:27Z

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8268727: Remove unused slowpath locking method in OptoRuntime

Reviewers

Dean Long (@dean-long - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk pull/4490/head:pull/4490
$ git checkout pull/4490

Update a local copy of the PR:
$ git checkout pull/4490
$ git pull https://git.openjdk.java.net/jdk pull/4490/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4490

View PR using the GUI difftool:
$ git pr show -t 4490

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk/pull/4490.diff

bridgekeeper · 2021-06-15T03:19:24Z

👋 Welcome back miao-zheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-06-15T03:21:50Z

@miao-zheng The following label will be automatically applied to this pull request:

hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2021-06-15T03:27:07Z

Webrevs

01: Full - Incremental (07b3280b)
00: Full (94db2f5d)

miao-zheng · 2021-06-15T07:30:11Z

/test

openjdk · 2021-06-15T07:31:20Z

@miao-zheng you need to get approval to run the tests in tier1 for commits up until 94db2f5

miao-zheng · 2021-06-21T02:24:42Z

Could someone help to review this change? Thanks.

dholmes-ora · 2021-06-21T02:49:54Z

/label add hotspot-compiler
/label remove hotspot-dev

openjdk · 2021-06-21T02:50:54Z

@dholmes-ora
The hotspot-compiler label was successfully added.

openjdk · 2021-06-21T02:52:51Z

@dholmes-ora
The hotspot label was successfully removed.

dholmes-ora · 2021-06-21T04:11:23Z

Redirecting to the compiler team.

zhengyu123 · 2021-06-21T11:36:03Z

test/lib/sun/hotspot/WhiteBox.java

@@ -310,7 +310,7 @@ public         void    makeMethodNotCompilable(Executable method, int compLevel,
    makeMethodNotCompilable0(method, compLevel, isOsr);
  }
  public        int     getMethodCompilationLevel(Executable method) {
-    return getMethodCompilationLevel(method, false /*not ost*/);
+    return getMethodCompilationLevel(method, false /*not osr*/);


This change is unrelated, should be fixed in a separate CR?

This is a small typo fix, can I merge it in this patch?

I think the convention is "no"

Got it. Thanks for your review. I have removed this change.

dean-long · 2021-06-22T22:36:33Z

/test

openjdk · 2021-06-22T22:39:46Z

Could not create test job

dean-long

Looks good, and trivial. It's strange that some pre-commit tests failed on Windows.

openjdk · 2021-06-23T01:52:48Z

⚠️ @miao-zheng the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8268727
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

openjdk · 2021-06-23T01:52:52Z

@miao-zheng This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268727: Remove unused slowpath locking method in OptoRuntime

Reviewed-by: dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 117 new commits pushed to the master branch:

cd678a3: 8268368: Adopt cast notation for JavaThread conversions
b6cfca8: Merge
35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
dc12cb7: 8267652: c2 loop unrolling by 8 results in reading memory past array
578c55b: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
8fa2520: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken
9ec7180: 8268524: nmethod::post_compiled_method_load_event racingly called on zombie
01f12fb: 8266631: StandardJavaFileManager: getJavaFileObjects() impl violates the spec
6b14c8a: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling
ef4ba22: 8268349: Provide clear run-time warnings about Security Manager deprecation
... and 107 more: https://git.openjdk.java.net/jdk/compare/9f3c7e74ff00a7550742ed8b9d6671c2d4bb6041...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@zhengyu123, @dean-long) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

miao-zheng · 2021-06-23T02:10:05Z

The same test cases fail in other Pull requests on windows, for example: #4534.
I think these test cases fail are random.

dean-long · 2021-06-23T02:31:33Z

I agree, test failures seem unrelated to this change.

miao-zheng · 2021-06-23T02:37:56Z

@dean-long @zhengyu123 Thanks for your review.

miao-zheng · 2021-06-23T02:39:07Z

/integrate

openjdk · 2021-06-23T02:40:54Z

@miao-zheng
Your change (at version 07b3280) is now ready to be sponsored by a Committer.

huishi-hs · 2021-06-23T02:44:18Z

/sponsor

openjdk · 2021-06-23T02:46:11Z

Going to push as commit ae3eedc.
Since your change was applied there have been 117 commits pushed to the master branch:

cd678a3: 8268368: Adopt cast notation for JavaThread conversions
b6cfca8: Merge
35e4c27: 8268404: [TESTBUG] tools/jpackage/windows/WinInstallerIconTest.java failed "AssertionError: Failed: Check icon"
dc12cb7: 8267652: c2 loop unrolling by 8 results in reading memory past array
578c55b: 8267399: C2: java/text/Normalizer/ConformanceTest.java test failed with assertion
8fa2520: 8268888: Upstream 8268230: Foreign Linker API & Windows user32/kernel32: String conversion seems broken
9ec7180: 8268524: nmethod::post_compiled_method_load_event racingly called on zombie
01f12fb: 8266631: StandardJavaFileManager: getJavaFileObjects() impl violates the spec
6b14c8a: 8267421: j.l.constant.DirectMethodHandleDesc.Kind.valueOf(int) implementation doesn't conform to the spec regarding REF_invokeInterface handling
ef4ba22: 8268349: Provide clear run-time warnings about Security Manager deprecation
... and 107 more: https://git.openjdk.java.net/jdk/compare/9f3c7e74ff00a7550742ed8b9d6671c2d4bb6041...master

Your commit was automatically rebased without conflicts.

openjdk · 2021-06-23T02:46:30Z

@huishi-hs @miao-zheng Pushed as commit ae3eedc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added hotspot rfr labels Jun 15, 2021

openjdk bot added the test-request label Jun 15, 2021

openjdk bot added the hotspot-compiler label Jun 21, 2021

openjdk bot removed the hotspot label Jun 21, 2021

zhengyu123 suggested changes Jun 21, 2021

View changes

8268727: Remove unused slowpath locking method in OptoRuntime

07b3280

miao-zheng force-pushed the 8268727 branch from 94db2f5 to 07b3280 Compare Jun 21, 2021

openjdk bot removed the test-request label Jun 22, 2021

dean-long approved these changes Jun 23, 2021

View changes

openjdk bot added the ready label Jun 23, 2021

openjdk bot added the sponsor label Jun 23, 2021

openjdk bot closed this Jun 23, 2021

openjdk bot added integrated and removed ready rfr sponsor labels Jun 23, 2021

8268727: Remove unused slowpath locking method in OptoRuntime #4490

8268727: Remove unused slowpath locking method in OptoRuntime #4490

miao-zheng commented Jun 15, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Jun 15, 2021

openjdk bot commented Jun 15, 2021

mlbridge bot commented Jun 15, 2021 •

edited

miao-zheng commented Jun 15, 2021

openjdk bot commented Jun 15, 2021

miao-zheng commented Jun 21, 2021

dholmes-ora commented Jun 21, 2021

openjdk bot commented Jun 21, 2021

openjdk bot commented Jun 21, 2021

dholmes-ora commented Jun 21, 2021

zhengyu123 Jun 21, 2021

miao-zheng Jun 21, 2021

zhengyu123 Jun 21, 2021

miao-zheng Jun 21, 2021

dean-long commented Jun 22, 2021

openjdk bot commented Jun 22, 2021

dean-long left a comment

openjdk bot commented Jun 23, 2021

openjdk bot commented Jun 23, 2021 •

edited

miao-zheng commented Jun 23, 2021

dean-long commented Jun 23, 2021

miao-zheng commented Jun 23, 2021

miao-zheng commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

huishi-hs commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

8268727: Remove unused slowpath locking method in OptoRuntime #4490

8268727: Remove unused slowpath locking method in OptoRuntime #4490

Conversation

miao-zheng commented Jun 15, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jun 15, 2021

openjdk bot commented Jun 15, 2021

mlbridge bot commented Jun 15, 2021 • edited

Webrevs

miao-zheng commented Jun 15, 2021

openjdk bot commented Jun 15, 2021

miao-zheng commented Jun 21, 2021

dholmes-ora commented Jun 21, 2021

openjdk bot commented Jun 21, 2021

openjdk bot commented Jun 21, 2021

dholmes-ora commented Jun 21, 2021

zhengyu123 Jun 21, 2021

Choose a reason for hiding this comment

miao-zheng Jun 21, 2021

Choose a reason for hiding this comment

zhengyu123 Jun 21, 2021

Choose a reason for hiding this comment

miao-zheng Jun 21, 2021

Choose a reason for hiding this comment

dean-long commented Jun 22, 2021

openjdk bot commented Jun 22, 2021

dean-long left a comment

openjdk bot commented Jun 23, 2021

openjdk bot commented Jun 23, 2021 • edited

miao-zheng commented Jun 23, 2021

dean-long commented Jun 23, 2021

miao-zheng commented Jun 23, 2021

miao-zheng commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

huishi-hs commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

openjdk bot commented Jun 23, 2021

miao-zheng commented Jun 15, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Jun 15, 2021 •

edited

openjdk bot commented Jun 23, 2021 •

edited