8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

[manukumarvs]

java/awt/PopupMenu/PopupMenuLocation.java seems to be unstable in MacOS machines, especially in MacOSX 12 machines. It seems to be a testbug as adding some stability improvements fix the issue. It intermittently fails in CI causing some noise. This test was already problem listed in windows due to an umbrella bug JDK-8238720. I have removed the problem listing and tested it in windows platform also, it works fine there.

Fix:
Some stability improvements have been done and the test has been run 100 times per platform in mach5 and got full PASS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

Reviewers

• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/9187/head:pull/9187
$ git checkout pull/9187

Update a local copy of the PR:
$ git checkout pull/9187
$ git pull https://git.openjdk.org/jdk pull/9187/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 9187

View PR using the GUI difftool:
$ git pr show -t 9187

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/9187.diff

[bridgekeeper]

👋 Welcome back mvs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@manukumarvs The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (50321cc2)
• 01: Full - Incremental (fbaa185a)
• 00: Full (271d6d4d)

[manukumarvs]

Any volunteers?

[manukumarvs]

Any volunteers please?

[manukumarvs]

Any volunteers?

[manukumarvs]

Any volunteers?

[openjdk]

@manukumarvs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288415: java/awt/PopupMenu/PopupMenuLocation.java is unstable in MacOS machines

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 335 new commits pushed to the master branch:

• 6e18883: 8290162: Reset recursion counter missed in fix of JDK-8224267
• 31f7fc0: 8283082: sun.security.x509.X509CertImpl.delete("x509.info.validity") nulls out info field
• d9ca438: Merge
• 3164c98: 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM
• c3806b9: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions
• 39715f3: 8287902: UnreadableRB case in MissingResourceCauseTest is not working reliably on Windows
• 62fbc3f: 8287379: Using @inheritdoc in an inapplicable context shouldn't crash javadoc
• fed3af8: 8287809: Revisit implementation of memory session
• e8568b8: 8290020: Deadlock in leakprofiler::emit_events during shutdown
• 7f0e9bd: 8289745: JfrStructCopyFailed uses heap words instead of bytes for object sizes
• ... and 325 more: https://git.openjdk.org/jdk/compare/cf4a4966a846ebea7e07c4ee6387fbf1081ea385...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[prrace]

8238720 is about failing when run on hi-dpi on windows. I don't see anything you've done to fix that

[prrace]

So if it hasn't passed in 5 seconds, you fail the test. How is that improving stability ?

[prrace]

ping ?

[bridgekeeper]

@manukumarvs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@manukumarvs This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.