8369992: JFR: Disable Placeholder-, LoaderConstraints- and ProtectionDomainCacheTableStatistics in default.jfc

[GoeLin]

I backport this for parity with 17.0.18-oracle.

First, there was the attempt to delete these events, see backport of https://bugs.openjdk.org/browse/JDK-8291733: Remove JFR events that expose hashtable

@eghalin pointed out to me that Oracle reverts this (See JDK-8369975 [BACKOUT BACKPORT] Remove JFR events that expose hashtable) and instead disables the events,
see also comment in #4047

This now implements the backport according to that comment.

Thanks again, Eric, for informing about this.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8369992 needs maintainer approval

Issue

• JDK-8369992: JFR: Disable Placeholder-, LoaderConstraints- and ProtectionDomainCacheTableStatistics in default.jfc (Bug - P3 - Approved)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4108/head:pull/4108
$ git checkout pull/4108

Update a local copy of the PR:
$ git checkout pull/4108
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4108/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4108

View PR using the GUI difftool:
$ git pr show -t 4108

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4108.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8369992: JFR: Disable Placeholder-, LoaderConstraints- and ProtectionDomainCacheTableStatistics in default.jfc

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 63406ab: 8364263: HttpClient: Improve encapsulation of ProxyServer
• 9e1a6be: 8367348: Enhance PassFailJFrame to support links in HTML
• f278bdc: 7191877: TEST_BUG: java/rmi/transport/checkLeaseInfoLeak/CheckLeaseLeak.java failing intermittently
• ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with the original issue, but not the original commit. If you have the original commit hash, please update the pull request title with Backport <hash>.

[mlbridge]

Webrevs

• 00: Full (236da3d6)

[GoeLin]

GHA failure: java/lang/ProcessBuilder/Basic#id0 failed. Unrelated.
Might be fixed by #4097

[MBaesken]

The JBS issue https://bugs.openjdk.org/browse/JDK-8369992 says the events 'add no value' and 'may cause performance regressions'.
So I wonder why we keep them in profile.jfc , at least in this commit profile.jfc was touched too
openjdk/jdk@b7d2bde

(in jdk head they are gone completely).

[MBaesken]

looks okay but see my comment .

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[GoeLin]

Hi @MBaesken

JDK-8291733 removed the feature in 20. Therefore the events
are gone in head, obviously.
Also, there was the attempt to backport the removal.
But Oracle then decided that this is too intrusive for a
update release.
In this comment #4047 (comment)
in the PR where I attempted to backport the removal to 17,
Eric advises me to do it exactly like I did in this change.
In some mail to me he also mentioned that they keep it in profile.jfc
so that people have the well known experience there.

Best, Goetz.

[GoeLin]

/integrate

[openjdk]

Going to push as commit d1813cc.
Since your change was applied there have been 12 commits pushed to the master branch:

• cd7abc8: 8304811: vmTestbase/vm/mlvm/indy/func/jvmti/stepBreakPopReturn/INDIFY_Test.java fails with JVMTI_ERROR_TYPE_MISMATCH
• d270974: 8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package
• 63406ab: 8364263: HttpClient: Improve encapsulation of ProxyServer
• ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/f4c80e318a4a72f5308310d352e5504414716fa4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit d1813cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.