8274315: JFR: One closed state per file or stream

[egahlin]

Hi,

This bug was filed to prevent intermittent failures, for example https://bugs.openjdk.java.net/browse/JDK-8268297, but turns out it didn't prevent that bug, but the problem stll exists.

Closed state is held in two places, both the ChunkParser and the EventStream. Since new instances of ChunkParser are created, where the closed stated is false initially, a thread may continue parsing longer than it should.

With the fix, there is only one closed state per recording or stream.

A follow up fix for JDK 19 may be to move the ParserConfiguration functionality into ParserState. I tried it initially, but there are some corner cases, so I rather wait.

Testing: jdk/jdk/jfr

Thanks
Erik

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8274315: JFR: One closed state per file or stream

Reviewers

• Markus Grönlund (@mgronlun - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk18 pull/62/head:pull/62
$ git checkout pull/62

Update a local copy of the PR:
$ git checkout pull/62
$ git pull https://git.openjdk.java.net/jdk18 pull/62/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 62

View PR using the GUI difftool:
$ git pr show -t 62

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk18/pull/62.diff

[bridgekeeper]

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@egahlin The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (02b4d2ee)

[mgronlun]

Looks good. Thanks.

[openjdk]

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274315: JFR: One closed state per file or stream

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the master branch:

• 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
• 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
• 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
• 84d3333: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms
• 1128674: 8278627: Shenandoah: TestHeapDump test failed
• 54517fa: 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64
• ac7430c: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
• db3d6d7: 8278087: Deserialization filter and filter factory property error reporting under specified
• 467f654: 8279011: JFR: JfrChunkWriter incorrectly handles int64_t chunk size as size_t
• 819f9bd: 8274323: compiler/codegen/aes/TestAESMain.java failed with "Error: invalid offset: -1434443640" after 8273297
• ... and 24 more: https://git.openjdk.java.net/jdk18/compare/9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[egahlin]

/integrate

[openjdk]

Going to push as commit dfb15c3.
Since your change was applied there have been 36 commits pushed to the master branch:

• e49d4a9: 8271447: java.nio.file.InvalidPathException: Malformed input or input contains unmappable characters
• 713fbeb: 8278987: RunThese24H.java failed with EXCEPTION_ACCESS_VIOLATION in write_sample_info
• 7341439: 8279007: jstatd fails to start because SecurityManager is disabled
• 97c5cd7: 8278508: Enable X86 maskAll instruction pattern for 32 bit JVM.
• 9ee3ccf: 8279045: Intrinsics missing vzeroupper instruction
• 84d3333: 8279081: ProblemList jdk/jfr/event/oldobject/TestLargeRootSet.java on 2 platforms
• 1128674: 8278627: Shenandoah: TestHeapDump test failed
• 54517fa: 8279074: ProblemList compiler/codecache/jmx/PoolsIndependenceTest.java on macosx-aarch64
• ac7430c: 8278044: ObjectInputStream methods invoking the OIF.CFG.getSerialFilterFactory() silent about error cases.
• db3d6d7: 8278087: Deserialization filter and filter factory property error reporting under specified
• ... and 26 more: https://git.openjdk.java.net/jdk18/compare/9a1bbaf8db0e869ab76be8ab1bd0ddeb23693e7e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin Pushed as commit dfb15c3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.